v3dv: add a comment to clarify how we should implement uuid / deviceID retrieval
authorIago Toral Quiroga <itoral@igalia.com>
Fri, 29 Nov 2019 09:22:26 +0000 (10:22 +0100)
committerMarge Bot <eric+marge@anholt.net>
Tue, 13 Oct 2020 21:21:25 +0000 (21:21 +0000)
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/6766>

src/broadcom/vulkan/v3dv_device.c

index 2bdec29..2e6441f 100644 (file)
@@ -543,6 +543,13 @@ v3dv_GetPhysicalDeviceProperties(VkPhysicalDevice physicalDevice,
       .nonCoherentAtomSize                      = 256,
    };
 
+   /* FIXME:
+    * Getting deviceID and UUID will probably require to use the kernel pci
+    * interface. See this:
+    * https://www.kernel.org/doc/html/latest/PCI/pci.html#how-to-find-pci-devices-manually
+    * And check the getparam ioctl in the i915 kernel with CHIPSET_ID for
+    * example.
+    */
    *pProperties = (VkPhysicalDeviceProperties) {
       .apiVersion = v3dv_physical_device_api_version(pdevice),
       .driverVersion = vk_get_driver_version(),