driver core: remove devm_device_remove_group()
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 9 Nov 2022 14:07:11 +0000 (15:07 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 10 Nov 2022 17:27:54 +0000 (18:27 +0100)
There is no in-kernel user of this function, so it is not needed anymore
and can be removed.

Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>
Reviewed-by: Rafael J. Wysocki <rafael@kernel.org>
Link: https://lore.kernel.org/r/20221109140711.105222-2-gregkh@linuxfoundation.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/base/core.c
include/linux/device.h

index 5fd99f2..af721e6 100644 (file)
@@ -2585,11 +2585,6 @@ union device_attr_group_devres {
        const struct attribute_group **groups;
 };
 
-static int devm_attr_group_match(struct device *dev, void *res, void *data)
-{
-       return ((union device_attr_group_devres *)res)->group == data;
-}
-
 static void devm_attr_group_remove(struct device *dev, void *res)
 {
        union device_attr_group_devres *devres = res;
@@ -2641,23 +2636,6 @@ int devm_device_add_group(struct device *dev, const struct attribute_group *grp)
 EXPORT_SYMBOL_GPL(devm_device_add_group);
 
 /**
- * devm_device_remove_group: remove a managed group from a device
- * @dev:       device to remove the group from
- * @grp:       group to remove
- *
- * This function removes a group of attributes from a device. The attributes
- * previously have to have been created for this group, otherwise it will fail.
- */
-void devm_device_remove_group(struct device *dev,
-                             const struct attribute_group *grp)
-{
-       WARN_ON(devres_release(dev, devm_attr_group_remove,
-                              devm_attr_group_match,
-                              /* cast away const */ (void *)grp));
-}
-EXPORT_SYMBOL_GPL(devm_device_remove_group);
-
-/**
  * devm_device_add_groups - create a bunch of managed attribute groups
  * @dev:       The device to create the group for
  * @groups:    The attribute groups to create, NULL terminated
index 4efc607..84ae52d 100644 (file)
@@ -1064,8 +1064,6 @@ int __must_check devm_device_add_groups(struct device *dev,
                                        const struct attribute_group **groups);
 int __must_check devm_device_add_group(struct device *dev,
                                       const struct attribute_group *grp);
-void devm_device_remove_group(struct device *dev,
-                             const struct attribute_group *grp);
 
 /*
  * Platform "fixup" functions - allow the platform to have their say