remove command keyword, convert to variable binding

diff --git a/README.markdown b/README.markdown
index da794002a80a616975828f78ac9609e0bc035f31..5a83e79b2db781ca9f6a6ee4e082d1d0ec4fa8ac 100644 (file)
--- a/README.markdown
+++ b/README.markdown
@@ -43,10 +43,13 @@ project, while `rule` statements describe how to generate the files
 within a given edge of the graph.
 
 ### Rules
-Here's an example of a simple rule for compiling C code.
+
+Rules begin with the `rule` keyword and a name for the rule, followed
+by an indented set of `key = val` lines.  Here's an example of a
+simple rule for compiling C code.
 
     rule cc
-    command gcc -c $in -o $out
+      command = gcc -c $in -o $out
 
 This declares a new rule named `cc`, along with the command to run.
 `Variables` begin with a `$` and are described more fully later, but
@@ -75,7 +78,7 @@ build files readable (debuggable), Ninja supports declaring bindings
 Can be used in a rule like this:
 
     rule cc
-    command gcc $cflags -c $in -o $out
+      command = gcc $cflags -c $in -o $out
 
 Variables might better be called "bindings", in that a given variable
 cannot be changed, only shadowed.  Within a larger Ninja project,

diff --git a/manifest_parser.h b/manifest_parser.h
index f0ebd5c7a6af5c91d71ef7f557a8793aab87e630..a46f16c807a62b64da28d6c5d778b5cfca42c5b1 100644 (file)
--- a/manifest_parser.h
+++ b/manifest_parser.h
@@ -7,7 +7,6 @@ struct Token {
     NONE,
     IDENT,
     RULE,
-    COMMAND,
     BUILD,
     NEWLINE,
     EQUALS,
@@ -23,7 +22,6 @@ struct Token {
     switch (type_) {
       case IDENT:   return "'" + extra_ + "'";
       case RULE:    return "'rule'";
-      case COMMAND: return "'command'";
       case BUILD:   return "'build'";
       case NEWLINE: return "newline";
       case EQUALS:  return "'='";
@@ -190,8 +188,6 @@ Token::Type Parser::PeekToken() {
     }
     if (token_.extra_ == "rule")
       token_.type_ = Token::RULE;
-    else if (token_.extra_ == "command")
-      token_.type_ = Token::COMMAND;
     else if (token_.extra_ == "build")
       token_.type_ = Token::BUILD;
     else
@@ -228,7 +224,7 @@ struct ManifestParser {
   bool Parse(const string& input, string* err);
 
   bool ParseRule(string* err);
-  bool ParseLet(string* err);
+  bool ParseLet(string* key, string* val, string* err);
   bool ParseEdge(string* err);
 
   string ExpandFile(const string& file);
@@ -276,10 +272,19 @@ bool ManifestParser::Parse(const string& input, string* err) {
         if (!ParseEdge(err))
           return false;
         break;
-      case Token::IDENT:
-        if (!ParseLet(err))
+      case Token::IDENT: {
+        string name, value;
+        if (!ParseLet(&name, &value, err))
           return false;
+
+        state_->AddBinding(name, value);
+        if (name == "builddir") {
+          builddir_ = value;
+          if (!builddir_.empty() && builddir_[builddir_.size() - 1] != '/')
+            builddir_.push_back('/');
+        }
         break;
+      }
       case Token::TEOF:
         continue;
       default:
@@ -304,39 +309,33 @@ bool ManifestParser::ParseRule(string* err) {
   if (parser_.PeekToken() == Token::INDENT) {
     parser_.ConsumeToken();
 
-    if (!parser_.ExpectToken(Token::COMMAND, err))
-      return false;
-    if (!parser_.ReadToNewline(&command, err))
-      return false;
+    while (parser_.PeekToken() != Token::OUTDENT) {
+      string key, val;
+      if (!ParseLet(&key, &val, err))
+        return false;
 
-    if (!parser_.ExpectToken(Token::OUTDENT, err))
-      return false;
+      if (key != "command") {
+        *err = "expected 'command'";
+        return false;
+      }
+      command = val;
+    }
+    parser_.ConsumeToken();
   }
 
-  state_->AddRule(name, command);
+  if (!command.empty())
+    state_->AddRule(name, command);
 
   return true;
 }
 
-bool ManifestParser::ParseLet(string* err) {
-  string name;
-  if (!parser_.ReadIdent(&name))
+bool ManifestParser::ParseLet(string* name, string* value, string* err) {
+  if (!parser_.ReadIdent(name))
     return parser_.Error("expected variable name", err);
-
   if (!parser_.ExpectToken(Token::EQUALS, err))
     return false;
-
-  string value;
-  if (!parser_.ReadToNewline(&value, err))
+  if (!parser_.ReadToNewline(value, err))
     return false;
-
-  state_->AddBinding(name, value);
-  if (name == "builddir") {
-    builddir_ = value;
-    if (!builddir_.empty() && builddir_[builddir_.size() - 1] != '/')
-      builddir_.push_back('/');
-  }
-
   return true;
 }
 

diff --git a/ninja_test.cc b/ninja_test.cc
index 2c1c4d50bbc28fba6f4f5e9d90432fe6d02eb142..b4b66653b7a97e3a5fc30b65575fd97437378e0d 100644 (file)
--- a/ninja_test.cc
+++ b/ninja_test.cc
@@ -22,10 +22,10 @@ TEST(Parser, Rules) {
   State state;
   ASSERT_NO_FATAL_FAILURE(AssertParse(&state,
 "rule cat\n"
-"  command cat @in > $out\n"
+"  command = cat @in > $out\n"
 "\n"
 "rule date\n"
-"  command date > $out\n"
+"  command = date > $out\n"
 "\n"
 "build result: cat in_1.cc in-2.O\n"));
 
@@ -39,7 +39,7 @@ TEST(Parser, Variables) {
   State state;
   ASSERT_NO_FATAL_FAILURE(AssertParse(&state,
 "rule link\n"
-"  command ld $extra $with_under -o $out @in\n"
+"  command = ld $extra $with_under -o $out @in\n"
 "\n"
 "extra = -pthread\n"
 "with_under = -under\n"
@@ -54,7 +54,7 @@ TEST(Parser, Continuation) {
   State state;
   ASSERT_NO_FATAL_FAILURE(AssertParse(&state,
 "rule link\n"
-"  command foo bar \\\n"
+"  command = foo bar \\\n"
 "    baz\n"
 "\n"
 "build a: link c \\\n"
@@ -114,7 +114,7 @@ TEST(Parser, Errors) {
   {
     ManifestParser parser(&state);
     string err;
-    EXPECT_FALSE(parser.Parse("rule cat\n  command cat ok\n"
+    EXPECT_FALSE(parser.Parse("rule cat\n  command = cat ok\n"
                               "build x: cat \\\n :\n",
                               &err));
     EXPECT_EQ("line 4, col 2: expected newline, got ':'", err);
@@ -126,7 +126,7 @@ TEST(Parser, BuildDir) {
   ASSERT_NO_FATAL_FAILURE(AssertParse(&state,
 "builddir = out\n"
 "rule cat\n"
-"  command cat @in > $out\n"
+"  command = cat @in > $out\n"
 "build @bin: cat @a.o\n"
 "build @a.o: cat a.cc\n"));
   state.stat_cache()->Dump();
@@ -179,7 +179,7 @@ struct StateTestWithBuiltinRules : public testing::Test {
   StateTestWithBuiltinRules() {
     AssertParse(&state_,
 "rule cat\n"
-"  command cat @in > $out\n");
+"  command = cat @in > $out\n");
   }
 
   Node* GetNode(const string& path) {