Add last OS error into heap stats.

That could allow us to understand why commit of from space sometimes fails.
Another option would be start a separate structure with OS-related info, but
as it's a single field, let's put it into HeapStats, at least for now.

Review URL: http://codereview.chromium.org/3118013

git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@5261 ce2b1a6d-e550-0410-aec6-3dcde31c8c00

diff --git a/src/api.cc b/src/api.cc
index b3164dd01eec2dbd41803c4c9ebec63e2a9da41a..8db8238b1fe96ee9962bb18bdc06063a9cbbf3d3 100644 (file)
--- a/src/api.cc
+++ b/src/api.cc
@@ -174,6 +174,8 @@ void i::V8::FatalProcessOutOfMemory(const char* location, bool take_snapshot) {
   heap_stats.objects_per_type = objects_per_type;
   int size_per_type[LAST_TYPE + 1] = {0};
   heap_stats.size_per_type = size_per_type;
+  int os_error;
+  heap_stats.os_error = &os_error;
   int end_marker;
   heap_stats.end_marker = &end_marker;
   i::Heap::RecordStats(&heap_stats, take_snapshot);

diff --git a/src/heap.cc b/src/heap.cc
index 50e6656d00aacea3c51ca6720125b6107704671c..1d696c7a167e1914ef092593fe9a49aa3c8627c9 100644 (file)
--- a/src/heap.cc
+++ b/src/heap.cc
@@ -4076,6 +4076,7 @@ void Heap::RecordStats(HeapStats* stats, bool take_snapshot) {
   *stats->memory_allocator_size = MemoryAllocator::Size();
   *stats->memory_allocator_capacity =
       MemoryAllocator::Size() + MemoryAllocator::Available();
+  *stats->os_error = OS::GetLastError();
   if (take_snapshot) {
     HeapIterator iterator;
     for (HeapObject* obj = iterator.next();

diff --git a/src/heap.h b/src/heap.h
index ac00827d3834717bed0563e242668dd8057a61fe..93b90b1846acbab3717e0ffc61c195dc06079bba 100644 (file)
--- a/src/heap.h
+++ b/src/heap.h
@@ -1345,7 +1345,8 @@ class HeapStats {
   int* memory_allocator_capacity;       // 20
   int* objects_per_type;                // 21
   int* size_per_type;                   // 22
-  int* end_marker;                      // 23
+  int* os_error;                        // 23
+  int* end_marker;                      // 24
 };
 
 

diff --git a/src/platform-nullos.cc b/src/platform-nullos.cc
index 656c317b62c516b87eaabbd5717f20a19ff75412..b8392e886ea60874f697d81146ea45c5902570e8 100644 (file)
--- a/src/platform-nullos.cc
+++ b/src/platform-nullos.cc
@@ -100,6 +100,12 @@ double OS::DaylightSavingsOffset(double time) {
 }
 
 
+int OS::GetLastError() {
+  UNIMPLEMENTED();
+  return 0;
+}
+
+
 // Returns the local time offset in milliseconds east of UTC without
 // taking daylight savings time into account.
 double OS::LocalTimeOffset() {

diff --git a/src/platform-posix.cc b/src/platform-posix.cc
index 613e8e4051f79ca80a7804340a5d023aa7f02653..c50d396ad3822542dbaf75c56986913d5c412618 100644 (file)
--- a/src/platform-posix.cc
+++ b/src/platform-posix.cc
@@ -108,6 +108,11 @@ double OS::DaylightSavingsOffset(double time) {
 }
 
 
+int OS::GetLastError() {
+  return errno;
+}
+
+
 // ----------------------------------------------------------------------------
 // POSIX stdio support.
 //

diff --git a/src/platform-win32.cc b/src/platform-win32.cc
index af3e9b2f3002281fab58f17b7f01ac55f2760491..86314a805e5dfb87a5eac8086b2702cfc0a39648 100644 (file)
--- a/src/platform-win32.cc
+++ b/src/platform-win32.cc
@@ -651,6 +651,11 @@ double OS::DaylightSavingsOffset(double time) {
 }
 
 
+int OS::GetLastError() {
+  return ::GetLastError();
+}
+
+
 // ----------------------------------------------------------------------------
 // Win32 console output.
 //

diff --git a/src/platform.h b/src/platform.h
index d63ca5e617358f98510404b9abc9fd89af2bcdb4..7539fd2ddb4d29132c22635a54a6155d52772f04 100644 (file)
--- a/src/platform.h
+++ b/src/platform.h
@@ -165,6 +165,9 @@ class OS {
   // Returns the daylight savings offset for the given time.
   static double DaylightSavingsOffset(double time);
 
+  // Returns last OS error.
+  static int GetLastError();
+
   static FILE* FOpen(const char* path, const char* mode);
 
   // Log file open mode is platform-dependent due to line ends issues.