mac80211: minstrel_ht: ignore frame that was sent with noAck flag
authorPhilipp Borgers <borgers@mi.fu-berlin.de>
Mon, 17 May 2021 12:01:45 +0000 (14:01 +0200)
committerJohannes Berg <johannes.berg@intel.com>
Wed, 23 Jun 2021 08:59:44 +0000 (10:59 +0200)
QoS Data Frames that were sent with a No Ack policy should be ignored by
the minstrel statistics. There will never be an Ack for these frames so
there is no way to draw conclusions about the success of the transmission.

Signed-off-by: Philipp Borgers <borgers@mi.fu-berlin.de>
Link: https://lore.kernel.org/r/20210517120145.132814-1-borgers@mi.fu-berlin.de
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/rc80211_minstrel_ht.c

index a6f3fb4..bc261d0 100644 (file)
@@ -1211,6 +1211,10 @@ minstrel_ht_tx_status(void *priv, struct ieee80211_supported_band *sband,
        bool last, update = false;
        int i;
 
+       /* Ignore packet that was sent with noAck flag */
+       if (info->flags & IEEE80211_TX_CTL_NO_ACK)
+               return;
+
        /* This packet was aggregated but doesn't carry status info */
        if ((info->flags & IEEE80211_TX_CTL_AMPDU) &&
            !(info->flags & IEEE80211_TX_STAT_AMPDU))