matroskamux: return TRUE from sink pad event function for tag events, which are handled
authorAndoni Morales Alastruey <amorales@flumotion.com>
Mon, 14 Mar 2011 14:46:50 +0000 (15:46 +0100)
committerTim-Philipp Müller <tim.muller@collabora.co.uk>
Mon, 14 Mar 2011 17:08:46 +0000 (17:08 +0000)
https://bugzilla.gnome.org/show_bug.cgi?id=644730

gst/matroska/matroska-mux.c

index 31fe40b..b94a434 100644 (file)
@@ -644,22 +644,23 @@ gst_matroska_mux_handle_sink_event (GstPad * pad, GstEvent * event)
       gst_tag_setter_merge_tags (GST_TAG_SETTER (mux), list,
           gst_tag_setter_get_tag_merge_mode (GST_TAG_SETTER (mux)));
 
-      /* handled this, don't want collectpads to forward it downstream */
-      ret = FALSE;
       gst_event_unref (event);
+      /* handled this, don't want collectpads to forward it downstream */
+      event = NULL;
       break;
     }
     case GST_EVENT_NEWSEGMENT:
       /* We don't support NEWSEGMENT events */
       ret = FALSE;
       gst_event_unref (event);
+      event = NULL;
       break;
     default:
       break;
   }
 
   /* now GstCollectPads can take care of the rest, e.g. EOS */
-  if (ret)
+  if (event)
     ret = mux->collect_event (pad, event);
 
   gst_object_unref (mux);