interconnect: qcom: rpm: allocate enough data in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Tue, 23 May 2023 10:27:28 +0000 (13:27 +0300)
committerGeorgi Djakov <djakov@kernel.org>
Mon, 29 May 2023 22:34:50 +0000 (01:34 +0300)
This was not allocating enough bytes.  There are two issue here.
First, there was a typo where it was taking the size of the pointer
instead of the size of the struct, "sizeof(qp->intf_clks)" vs
"sizeof(*qp->intf_clks)".  Second, it's an array of "cd_num" clocks so
we need to allocate space for more than one element.

Fixes: 2e2113c8a64f ("interconnect: qcom: rpm: Handle interface clocks")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Konrad Dybcio <konrad.dybcio@linaro.org>
Link: https://lore.kernel.org/r/e0fa275c-ae63-4342-9c9e-0ffaf6314da1@kili.mountain
Signed-off-by: Georgi Djakov <djakov@kernel.org>
drivers/interconnect/qcom/icc-rpm.c

index f4627c4..6acc768 100644 (file)
@@ -436,7 +436,7 @@ int qnoc_probe(struct platform_device *pdev)
        if (!qp)
                return -ENOMEM;
 
-       qp->intf_clks = devm_kzalloc(dev, sizeof(qp->intf_clks), GFP_KERNEL);
+       qp->intf_clks = devm_kcalloc(dev, cd_num, sizeof(*qp->intf_clks), GFP_KERNEL);
        if (!qp->intf_clks)
                return -ENOMEM;