crypto: octeontx2 - uninitialized variable in kvf_limits_store()
authorDan Carpenter <dan.carpenter@oracle.com>
Sat, 27 Nov 2021 14:10:27 +0000 (17:10 +0300)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 3 Dec 2021 04:56:43 +0000 (15:56 +1100)
If kstrtoint() fails then "lfs_num" is uninitialized and the warning
doesn't make any sense.  Just delete it.

Fixes: 8ec8015a3168 ("crypto: octeontx2 - add support to process the crypto request")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c

index 146a55a..be1ad55 100644 (file)
@@ -494,12 +494,11 @@ static ssize_t kvf_limits_store(struct device *dev,
 {
        struct otx2_cptpf_dev *cptpf = dev_get_drvdata(dev);
        int lfs_num;
+       int ret;
 
-       if (kstrtoint(buf, 0, &lfs_num)) {
-               dev_err(dev, "lfs count %d must be in range [1 - %d]\n",
-                       lfs_num, num_online_cpus());
-               return -EINVAL;
-       }
+       ret = kstrtoint(buf, 0, &lfs_num);
+       if (ret)
+               return ret;
        if (lfs_num < 1 || lfs_num > num_online_cpus()) {
                dev_err(dev, "lfs count %d must be in range [1 - %d]\n",
                        lfs_num, num_online_cpus());