cpufreq: amd_pstate: map desired perf into pstate scope for powersave governor
authorPerry Yuan <Perry.Yuan@amd.com>
Sun, 14 Aug 2022 16:35:46 +0000 (00:35 +0800)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Wed, 31 Aug 2022 19:05:38 +0000 (21:05 +0200)
The patch will fix the invalid desired perf value for powersave
governor. This issue is found when testing on one AMD EPYC system, the
actual des_perf is smaller than the min_perf value, that is invalid
value. because the min_perf is the lowest_perf system can support in
idle state.

Reviewed-by: Huang Rui <ray.huang@amd.com>
Signed-off-by: Perry Yuan <Perry.Yuan@amd.com>
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
drivers/cpufreq/amd-pstate.c

index a47a1a2..fd563a0 100644 (file)
@@ -269,6 +269,7 @@ static void amd_pstate_update(struct amd_cpudata *cpudata, u32 min_perf,
        u64 prev = READ_ONCE(cpudata->cppc_req_cached);
        u64 value = prev;
 
+       des_perf = clamp_t(unsigned long, des_perf, min_perf, max_perf);
        value &= ~AMD_CPPC_MIN_PERF(~0L);
        value |= AMD_CPPC_MIN_PERF(min_perf);
 
@@ -357,8 +358,6 @@ static void amd_pstate_adjust_perf(unsigned int cpu,
        if (max_perf < min_perf)
                max_perf = min_perf;
 
-       des_perf = clamp_t(unsigned long, des_perf, min_perf, max_perf);
-
        amd_pstate_update(cpudata, min_perf, des_perf, max_perf, true);
 }