nvdimm: make security_show static
authorBen Dooks <ben.dooks@codethink.co.uk>
Fri, 16 Jun 2023 16:09:25 +0000 (17:09 +0100)
committerVishal Verma <vishal.l.verma@intel.com>
Fri, 23 Jun 2023 21:08:24 +0000 (15:08 -0600)
The security_show function is not used outside of drivers/nvdimm/dimm_devs.c
and the attribute it is for is also already static. Silence the sparse
warning for this not being declared by making it static. Fixes:

  drivers/nvdimm/dimm_devs.c:352:9: warning: symbol 'security_show' was not declared. Should it be static?

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
Link: https://lore.kernel.org/r/20230616160925.17687-1-ben.dooks@codethink.co.uk
Reviewed-by: Dave Jiang <dave.jiang@intel.com>
Signed-off-by: Vishal Verma <vishal.l.verma@intel.com>
drivers/nvdimm/dimm_devs.c

index 10c3cb6..1273873 100644 (file)
@@ -350,7 +350,7 @@ static ssize_t available_slots_show(struct device *dev,
 static DEVICE_ATTR_RO(available_slots);
 
 static ssize_t security_show(struct device *dev,
-               struct device_attribute *attr, char *buf)
+                            struct device_attribute *attr, char *buf)
 {
        struct nvdimm *nvdimm = to_nvdimm(dev);