drm/amdgpu: only set cp active field for kiq queue

The mec ucode will set the CP_HQD_ACTIVE bit while the queue is mapped by
MAP_QUEUES packet. So we only need set cp active field for kiq queue.

Signed-off-by: Huang Rui <ray.huang@amd.com>
Reviewed-by: Felix Kuehling <Felix.Kuehling@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
index 468f1b1d41e76b2e52277fc0470c8f6a018a2bf6..874f641de2819d993bf6cf4e61e94ddc0f74e46c 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v10_0.c
@@ -3337,8 +3337,11 @@ static int gfx_v10_0_compute_mqd_init(struct amdgpu_ring *ring)
        tmp = REG_SET_FIELD(tmp, CP_HQD_IB_CONTROL, MIN_IB_AVAIL_SIZE, 3);
        mqd->cp_hqd_ib_control = tmp;
 
-       /* activate the queue */
-       mqd->cp_hqd_active = 1;
+       /* map_queues packet doesn't need activate the queue,
+        * so only kiq need set this field.
+        */
+       if (ring->funcs->type == AMDGPU_RING_TYPE_KIQ)
+               mqd->cp_hqd_active = 1;
 
        return 0;
 }

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
index cfc1403fc855a2d1b1f7871e36a047f1ba03b558..46f0533ba43fe307b1a67a8961b02acfc881e554 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v8_0.c
@@ -4558,8 +4558,11 @@ static int gfx_v8_0_mqd_init(struct amdgpu_ring *ring)
        mqd->cp_hqd_eop_wptr_mem = RREG32(mmCP_HQD_EOP_WPTR_MEM);
        mqd->cp_hqd_eop_dones = RREG32(mmCP_HQD_EOP_DONES);
 
-       /* activate the queue */
-       mqd->cp_hqd_active = 1;
+       /* map_queues packet doesn't need activate the queue,
+        * so only kiq need set this field.
+        */
+       if (ring->funcs->type == AMDGPU_RING_TYPE_KIQ)
+               mqd->cp_hqd_active = 1;
 
        return 0;
 }

diff --git a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
index 388a38febb4e31116a06e7827f5c4e6ce6c76897..46ab46757b25756afa0c8e37ce57b9441ec702bd 100644 (file)
--- a/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
+++ b/drivers/gpu/drm/amd/amdgpu/gfx_v9_0.c
@@ -3370,8 +3370,11 @@ static int gfx_v9_0_mqd_init(struct amdgpu_ring *ring)
        tmp = REG_SET_FIELD(tmp, CP_HQD_IB_CONTROL, MIN_IB_AVAIL_SIZE, 3);
        mqd->cp_hqd_ib_control = tmp;
 
-       /* activate the queue */
-       mqd->cp_hqd_active = 1;
+       /* map_queues packet doesn't need activate the queue,
+        * so only kiq need set this field.
+        */
+       if (ring->funcs->type == AMDGPU_RING_TYPE_KIQ)
+               mqd->cp_hqd_active = 1;
 
        return 0;
 }