projects
/
sdk
/
emulator
/
qemu.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
04c5b17
)
hw/lan9118.c: Add missing 'break' to fix buffer overrun
author
Peter Maydell
<peter.maydell@linaro.org>
Wed, 9 Nov 2011 18:59:54 +0000
(18:59 +0000)
committer
Stefan Hajnoczi
<stefanha@linux.vnet.ibm.com>
Thu, 10 Nov 2011 12:29:50 +0000
(12:29 +0000)
Add a missing 'break' statement to fix a buffer overrun when
executing the EEPROM write-all command. Spotted by Coverity
(see bug 887883).
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
hw/lan9118.c
patch
|
blob
|
history
diff --git
a/hw/lan9118.c
b/hw/lan9118.c
index
634b88e
..
f8149e6
100644
(file)
--- a/
hw/lan9118.c
+++ b/
hw/lan9118.c
@@
-863,6
+863,7
@@
static void lan9118_eeprom_cmd(lan9118_state *s, int cmd, int addr)
} else {
DPRINTF("EEPROM Write All (ignored)\n");
}
+ break;
case 5: /* ERASE */
if (s->eeprom_writable) {
s->eeprom[addr] = 0xff;