scsi: hpsa: Do not set COMMAND_COMPLETE
authorHannes Reinecke <hare@suse.de>
Wed, 13 Jan 2021 09:04:41 +0000 (10:04 +0100)
committerMartin K. Petersen <martin.petersen@oracle.com>
Sat, 23 Jan 2021 02:14:09 +0000 (21:14 -0500)
COMMAND_COMPLETE is defined as '0', and it is a SCSI parallel message to
boot. Drop the call to set_msg_byte().

Link: https://lore.kernel.org/r/20210113090500.129644-17-hare@suse.de
Reviewed-by: Christoph Hellwig <hch@lst.de>
Acked-by: Don Brace <don.brace@microchip.com>
Signed-off-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/hpsa.c

index f4d3747..337d3aa 100644 (file)
@@ -2396,7 +2396,6 @@ static int handle_ioaccel_mode2_error(struct ctlr_info *h,
                        break;
                case IOACCEL2_STATUS_SR_UNDERRUN:
                        cmd->result = (DID_OK << 16);           /* host byte */
-                       cmd->result |= (COMMAND_COMPLETE << 8); /* msg byte */
                        ioaccel2_resid = get_unaligned_le32(
                                                &c2->error_data.resid_cnt[0]);
                        scsi_set_resid(cmd, ioaccel2_resid);
@@ -2597,8 +2596,7 @@ static void complete_scsi_command(struct CommandList *cp)
                (c2->sg[0].chain_indicator == IOACCEL2_CHAIN))
                hpsa_unmap_ioaccel2_sg_chain_block(h, c2);
 
-       cmd->result = (DID_OK << 16);           /* host byte */
-       cmd->result |= (COMMAND_COMPLETE << 8); /* msg byte */
+       cmd->result = (DID_OK << 16);           /* host byte */
 
        /* SCSI command has already been cleaned up in SML */
        if (dev->was_removed) {