Merge remote-tracking branch 'dotnet/master' into RemoveNetcoreappNetfxBuildScripts
authorSantiago Fernandez Madero <safern@microsoft.com>
Thu, 23 Jan 2020 17:57:10 +0000 (09:57 -0800)
committerSantiago Fernandez Madero <safern@microsoft.com>
Thu, 23 Jan 2020 17:57:10 +0000 (09:57 -0800)
15 files changed:
1  2 
docs/project/library-servicing.md
docs/workflow/building/libraries/README.md
eng/build.ps1
eng/build.sh
eng/pipelines/installer/jobs/base-job.yml
eng/pipelines/libraries/base-job.yml
eng/pipelines/libraries/build-job.yml
eng/pipelines/libraries/build-test-job.yml
eng/pipelines/libraries/helix-queues-setup.yml
eng/pipelines/libraries/helix.yml
eng/pipelines/libraries/outerloop.yml
eng/pipelines/libraries/run-test-job.yml
eng/pipelines/runtime.yml
src/libraries/Directory.Build.props
src/libraries/sendtohelix.proj

Simple merge
diff --cc eng/build.ps1
@@@ -118,16 -132,18 +132,17 @@@ foreach ($argument in $PSBoundParameter
  {
    switch($argument)
    {
-     "build"             { $arguments += " -build" }
-     "buildtests"        { if ($build -eq $true) { $arguments += " /p:BuildTests=true" } else { $arguments += " -build /p:BuildTests=only" } }
-     "test"              { $arguments += " -test" }
-     "configuration"     { $configuration = (Get-Culture).TextInfo.ToTitleCase($($PSBoundParameters[$argument])); $arguments += " /p:ConfigurationGroup=$configuration -configuration $configuration" }
-     "framework"         { $arguments += " /p:TargetGroup=$($PSBoundParameters[$argument].ToLowerInvariant())" }
-     "os"                { $arguments += " /p:OSGroup=$($PSBoundParameters[$argument])" }
-     "allconfigurations" { $arguments += " /p:BuildAllConfigurations=true" }
-     "arch"              { $arguments += " /p:ArchGroup=$($PSBoundParameters[$argument]) /p:TargetArchitecture=$($PSBoundParameters[$argument])" }
-     "properties"        { $arguments += " " + $properties }
-     default             { $arguments += " /p:$argument=$($PSBoundParameters[$argument])" }
+     "build"                { $arguments += " -build" }
+     "buildtests"           { if ($build -eq $true) { $arguments += " /p:BuildTests=true" } else { $arguments += " -build /p:BuildTests=only" } }
+     "test"                 { $arguments += " -test" }
+     "configuration"        { $configuration = (Get-Culture).TextInfo.ToTitleCase($($PSBoundParameters[$argument])); $arguments += " /p:ConfigurationGroup=$configuration -configuration $configuration" }
+     "runtimeConfiguration" { $arguments += " /p:RuntimeConfiguration=$((Get-Culture).TextInfo.ToTitleCase($($PSBoundParameters[$argument])))" }
 -    # This should be removed after we have finalized our ci build pipeline.
 -    "framework"            { if ($PSBoundParameters[$argument].ToLowerInvariant() -eq 'netcoreapp') { $arguments += " /p:TargetGroup=netcoreapp5.0" } else { if ($PSBoundParameters[$argument].ToLowerInvariant() -eq 'netfx') { $arguments += " /p:TargetGroup=net472" } else { $arguments += " /p:TargetGroup=$($PSBoundParameters[$argument].ToLowerInvariant())"}}}
++    "framework"            { $arguments += " /p:TargetGroup=$($PSBoundParameters[$argument].ToLowerInvariant())" }
+     "os"                   { $arguments += " /p:OSGroup=$($PSBoundParameters[$argument])" }
+     "allconfigurations"    { $arguments += " /p:BuildAllConfigurations=true" }
+     "arch"                 { $arguments += " /p:ArchGroup=$($PSBoundParameters[$argument]) /p:TargetArchitecture=$($PSBoundParameters[$argument])" }
+     "properties"           { $arguments += " " + $properties }
+     default                { $arguments += " /p:$argument=$($PSBoundParameters[$argument])" }
    }
  }
  
diff --cc eng/build.sh
Simple merge
@@@ -312,9 -314,9 +314,9 @@@ jobs
          parameters.osGroup,
          parameters.osSubgroup,
          parameters.archType,
-         parameters.liveCoreClrBuildConfig) }}
+         parameters.liveRuntimeBuildConfig) }}
    - ${{ if ne(parameters.liveLibrariesBuildConfig, '') }}:
 -    - libraries_build_netcoreapp_${{ format('{0}{1}_{2}_{3}',
 +    - libraries_build_${{ format('{0}{1}_{2}_{3}',
          parameters.osGroup,
          parameters.osSubgroup,
          parameters.archType,
      - libraries_build_allconfigurations_Windows_NT_x64_Release
    - ${{ if eq(parameters.buildFullPlatformManifest, true) }}:
      - ${{ each platform in parameters.platforms }}:
-       - coreclr_product_build_${{ platform }}_${{ parameters.liveCoreClrBuildConfig }}
+       - ${{ parameters.runtimeFlavor }}_product_build_${{ platform }}_${{ parameters.liveRuntimeBuildConfig }}
 -      - libraries_build_netcoreapp_${{ platform }}_${{ parameters.liveLibrariesBuildConfig }}
 +      - libraries_build_${{ platform }}_${{ parameters.liveLibrariesBuildConfig }}
  
    steps:
  
Simple merge
Simple merge
@@@ -3,9 -3,9 +3,9 @@@ parameters
    osGroup: ''
    osSubgroup: ''
    archType: ''
 -  framework: netcoreapp
 +  framework: ''
    isOfficialBuild: false
-   liveCoreClrBuildConfig: ''
+   liveRuntimeBuildConfig: ''
    timeoutInMinutes: 150
    container: ''
    publishTestArtifacs: true
Simple merge
@@@ -61,9 -61,10 +61,9 @@@ jobs
        jobParameters:
          isOfficialBuild: ${{ variables['isOfficialBuild'] }}
          isFullMatrix: ${{ variables['isFullMatrix'] }}
 -        framework: netcoreapp
          runTests: true
          testScope: outerloop
-         liveCoreClrBuildConfig: release
+         liveRuntimeBuildConfig: release
    
    - ${{ if eq(variables['isFullMatrix'], false) }}:
      - template: /eng/pipelines/common/platform-matrix.yml
          jobParameters:
            isOfficialBuild: ${{ variables['isOfficialBuild'] }}
            isFullMatrix: ${{ variables['isFullMatrix'] }}
 -          framework: netcoreapp
            runTests: true
            testScope: outerloop
-           liveCoreClrBuildConfig: release
+           liveRuntimeBuildConfig: release
  
    - ${{ if eq(variables['includeWindowsOuterloop'], true) }}:
      - template: /eng/pipelines/common/platform-matrix.yml
@@@ -3,9 -3,10 +3,10 @@@ parameters
    osGroup: ''
    osSubgroup: ''
    archType: ''
 -  framework: netcoreapp
 +  framework: ''
    isOfficialBuild: false
-   liveCoreClrBuildConfig: ''
+   liveRuntimeBuildConfig: ''
+   runtimeFlavor: 'coreclr'
    timeoutInMinutes: 150
    pool: ''
    testScope: ''
@@@ -37,14 -39,10 +39,14 @@@ jobs
          name: test_run
  
        dependsOn:
 -      - ${{ format('libraries_build_{0}_{1}{2}_{3}_{4}', parameters.framework, parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.buildConfig) }}
 -      - ${{ format('libraries_test_build_{0}_{1}_{2}_{3}', parameters.framework, parameters.osGroup, parameters.dependsOnTestArchitecture, parameters.dependsOnTestBuildConfiguration) }}
 +      - ${{ if notIn(parameters.framework, 'allConfigurations', 'net472') }}:
 +        - ${{ format('libraries_build_{0}{1}_{2}_{3}', parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.buildConfig) }}
 +        - ${{ format('libraries_test_build_{0}_{1}_{2}', parameters.osGroup, parameters.dependsOnTestArchitecture, parameters.dependsOnTestBuildConfiguration) }}
 +      - ${{ if in(parameters.framework, 'allConfigurations', 'net472') }}:
 +        - ${{ format('libraries_build_{0}_{1}{2}_{3}_{4}', parameters.framework, parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.buildConfig) }}
 +        - ${{ format('libraries_test_build_{0}_{1}_{2}_{3}', parameters.framework, parameters.osGroup, parameters.dependsOnTestArchitecture, parameters.dependsOnTestBuildConfiguration) }}
-       - ${{ if ne(parameters.liveCoreClrBuildConfig, '') }}:
-         - ${{ format('coreclr_product_build_{0}{1}_{2}_{3}', parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.liveCoreClrBuildConfig) }}
+       - ${{ if ne(parameters.liveRuntimeBuildConfig, '') }}:
+         - ${{ format('{0}_product_build_{1}{2}_{3}_{4}', parameters.runtimeFlavor, parameters.osGroup, parameters.osSubgroup, parameters.archType, parameters.liveRuntimeBuildConfig) }}
  
        variables:
          - librariesTestsArtifactName: ${{ format('libraries_test_assets_{0}_{1}_{2}', parameters.osGroup, parameters.dependsOnTestArchitecture, parameters.dependsOnTestBuildConfiguration) }}
@@@ -218,7 -285,8 +285,7 @@@ jobs
      - ${{ if eq(variables['isFullMatrix'], false) }}:
        - Windows_NT_x86
      jobParameters:
-       liveCoreClrBuildConfig: release
 -      framework: netcoreapp
+       liveRuntimeBuildConfig: release
        condition: >-
          or(
            eq(dependencies.checkout.outputs['SetPathVars_libraries.containsChange'], true),
            eq(variables['isFullMatrix'], true))
  
  #
- # Libraries Release Test Execution against a release runtime
+ # Libraries Release Test Execution against a release mono runtime.
+ #
+ - template: /eng/pipelines/common/platform-matrix.yml
+   parameters:
+     jobTemplate: /eng/pipelines/libraries/run-test-job.yml
+     runtimeFlavor: mono
+     buildConfig: ${{ variables.debugOnPrReleaseOnRolling }}
+     platforms:
+     # - Windows_NT_x64
+     - OSX_x64
+     - Linux_x64
+     helixQueuesTemplate: /eng/pipelines/libraries/helix-queues-setup.yml
+     jobParameters:
+       isOfficialBuild: false
+       isFullMatrix: ${{ variables.isFullMatrix }}
 -      framework: netcoreapp
+       testScope: innerloop
+       liveRuntimeBuildConfig: release
+       dependsOnTestBuildConfiguration: ${{ variables.debugOnPrReleaseOnRolling }}
+       dependsOnTestArchitecture: x64
+ #
+ # Libraries Release Test Execution against a release coreclr runtime
  # Only when the PR contains a libraries change
  #
  - template: /eng/pipelines/common/platform-matrix.yml
      jobParameters:
        isOfficialBuild: false
        isFullMatrix: ${{ variables.isFullMatrix }}
 -      framework: netcoreapp
        testScope: innerloop
-       liveCoreClrBuildConfig: release
+       liveRuntimeBuildConfig: release
        dependsOnTestBuildConfiguration: ${{ variables.debugOnPrReleaseOnRolling }}
        dependsOnTestArchitecture: x64
        condition: >-
      jobParameters:
        isOfficialBuild: false
        isFullMatrix: ${{ variables.isFullMatrix }}
 -      framework: netcoreapp
        testScope: innerloop
-       liveCoreClrBuildConfig: release
+       liveRuntimeBuildConfig: release
        dependsOnTestBuildConfiguration: ${{ variables.debugOnPrReleaseOnRolling }}
        dependsOnTestArchitecture: x64
        condition: >-
      helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml
      helixQueueGroup: libraries
      jobParameters:
 -      framework: netcoreapp
        testScope: innerloop
-       liveCoreClrBuildConfig: checked
+       liveRuntimeBuildConfig: checked
        dependsOnTestBuildConfiguration: ${{ variables.debugOnPrReleaseOnRolling }}
        dependsOnTestArchitecture: x64
        condition: >-
      helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml
      helixQueueGroup: libraries
      jobParameters:
 -      framework: netcoreapp
        testScope: innerloop
-       liveCoreClrBuildConfig: checked
+       liveRuntimeBuildConfig: checked
        dependsOnTestBuildConfiguration: ${{ variables.debugOnPrReleaseOnRolling }}
        dependsOnTestArchitecture: x64
        condition: >-
      helixQueuesTemplate: /eng/pipelines/coreclr/templates/helix-queues-setup.yml
      helixQueueGroup: libraries
      jobParameters:
 -      framework: netcoreapp
        testScope: innerloop
-       liveCoreClrBuildConfig: checked
+       liveRuntimeBuildConfig: checked
        dependsOnTestBuildConfiguration: ${{ variables.debugOnPrReleaseOnRolling }}
        dependsOnTestArchitecture: x64
        condition: >-
Simple merge
Simple merge