net: phy: marvell: Replace mdelay() with msleep() in m88e1116r_config_init()
authorJia-Ju Bai <baijiaju1990@gmail.com>
Fri, 27 Jul 2018 08:34:25 +0000 (16:34 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 27 Jul 2018 20:45:14 +0000 (13:45 -0700)
m88e1116r_config_init() is never called in atomic context.
It calls mdelay() to busily wait, which is not necessary.
mdelay() can be replaced with msleep().

This is found by a static analysis tool named DCNS written by myself.

Signed-off-by: Jia-Ju Bai <baijiaju1990@gmail.com>
Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/phy/marvell.c

index 1cd439bdf6087af2913f589b499cd5c5abe5a3bb..f7c69ca34056e0e9846301b2637e6547688a91de 100644 (file)
@@ -679,7 +679,7 @@ static int m88e1116r_config_init(struct phy_device *phydev)
        if (err < 0)
                return err;
 
-       mdelay(500);
+       msleep(500);
 
        err = marvell_set_page(phydev, MII_MARVELL_COPPER_PAGE);
        if (err < 0)