RDMA/cxgb3: Don't expose DMA addresses
authorLeon Romanovsky <leonro@mellanox.com>
Mon, 20 May 2019 06:54:29 +0000 (09:54 +0300)
committerJason Gunthorpe <jgg@mellanox.com>
Mon, 27 May 2019 17:24:03 +0000 (14:24 -0300)
DMA addresses like all other kernel addresses should be printed with
special %p* formatter. It is needed to allow control of exposure of such
information through a dedicated knob.

Signed-off-by: Leon Romanovsky <leonro@mellanox.com>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/cxgb3/cxio_hal.c
drivers/infiniband/hw/cxgb3/iwch_provider.c

index e9a5f45..73bc6b8 100644 (file)
@@ -565,9 +565,9 @@ static int cxio_hal_init_ctrl_qp(struct cxio_rdev *rdev_p)
        wqe->sge_cmd = cpu_to_be64(sge_cmd);
        wqe->ctx1 = cpu_to_be64(ctx1);
        wqe->ctx0 = cpu_to_be64(ctx0);
-       pr_debug("CtrlQP dma_addr 0x%llx workq %p size %d\n",
-                (unsigned long long)rdev_p->ctrl_qp.dma_addr,
-                rdev_p->ctrl_qp.workq, 1 << T3_CTRL_QP_SIZE_LOG2);
+       pr_debug("CtrlQP dma_addr %pad workq %p size %d\n",
+                &rdev_p->ctrl_qp.dma_addr, rdev_p->ctrl_qp.workq,
+                1 << T3_CTRL_QP_SIZE_LOG2);
        skb->priority = CPL_PRIORITY_CONTROL;
        return iwch_cxgb3_ofld_send(rdev_p->t3cdev_p, skb);
 err:
index 82669c2..7e6adf0 100644 (file)
@@ -205,9 +205,9 @@ static struct ib_cq *iwch_create_cq(struct ib_device *ibdev,
                }
                insert_mmap(ucontext, mm);
        }
-       pr_debug("created cqid 0x%0x chp %p size 0x%0x, dma_addr 0x%0llx\n",
+       pr_debug("created cqid 0x%0x chp %p size 0x%0x, dma_addr %pad\n",
                 chp->cq.cqid, chp, (1 << chp->cq.size_log2),
-                (unsigned long long)chp->cq.dma_addr);
+                &chp->cq.dma_addr);
        return &chp->ibcq;
 }
 
@@ -919,10 +919,11 @@ static struct ib_qp *iwch_create_qp(struct ib_pd *pd,
                insert_mmap(ucontext, mm2);
        }
        qhp->ibqp.qp_num = qhp->wq.qpid;
-       pr_debug("%s sq_num_entries %d, rq_num_entries %d qpid 0x%0x qhp %p dma_addr 0x%llx size %d rq_addr 0x%x\n",
-                __func__, qhp->attr.sq_num_entries, qhp->attr.rq_num_entries,
-                qhp->wq.qpid, qhp, (unsigned long long)qhp->wq.dma_addr,
-                1 << qhp->wq.size_log2, qhp->wq.rq_addr);
+       pr_debug(
+               "%s sq_num_entries %d, rq_num_entries %d qpid 0x%0x qhp %p dma_addr %pad size %d rq_addr 0x%x\n",
+               __func__, qhp->attr.sq_num_entries, qhp->attr.rq_num_entries,
+               qhp->wq.qpid, qhp, &qhp->wq.dma_addr, 1 << qhp->wq.size_log2,
+               qhp->wq.rq_addr);
        return &qhp->ibqp;
 }