l2tp: remove BUG_ON refcount value in l2tp_session_free
authorTom Parkin <tparkin@katalix.com>
Fri, 24 Jul 2020 15:31:56 +0000 (16:31 +0100)
committerDavid S. Miller <davem@davemloft.net>
Sat, 25 Jul 2020 00:19:14 +0000 (17:19 -0700)
l2tp_session_free is only called by l2tp_session_dec_refcount when the
reference count reaches zero, so it's of limited value to validate the
reference count value in l2tp_session_free itself.

Signed-off-by: Tom Parkin <tparkin@katalix.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/l2tp/l2tp_core.c

index e228480..50548c6 100644 (file)
@@ -1563,8 +1563,6 @@ void l2tp_session_free(struct l2tp_session *session)
 {
        struct l2tp_tunnel *tunnel = session->tunnel;
 
-       BUG_ON(refcount_read(&session->ref_count) != 0);
-
        if (tunnel) {
                BUG_ON(tunnel->magic != L2TP_TUNNEL_MAGIC);
                l2tp_tunnel_dec_refcount(tunnel);