Fix typeo in LoadBinariesViaExhaustiveSearch when looking for kernel
authorJason Molenda <jason@molenda.com>
Thu, 5 Jan 2023 00:08:58 +0000 (16:08 -0800)
committerJason Molenda <jason@molenda.com>
Thu, 5 Jan 2023 00:11:51 +0000 (16:11 -0800)
As a last resort, with a Mach-O corefile, lldb will iterate through
all memory segments looking for a dyld binary (for a userland process
core dump) or an xnu kernel binary (kernel coredump).  We often
have metadata via LC_NOTEs so this final search mechanism is not
needed.  During the rewrite in https://reviews.llvm.org/D133680 I
did not handle the case of finding the xnu kernel by exhaustive
search correctly.

rdar://103813200

lldb/source/Plugins/Process/mach-core/ProcessMachCore.cpp

index 593dc85..fbf57fc 100644 (file)
@@ -357,7 +357,7 @@ void ProcessMachCore::LoadBinariesViaExhaustiveSearch() {
         if (dyld != LLDB_INVALID_ADDRESS)
           dylds_found.push_back(dyld);
         if (kernel != LLDB_INVALID_ADDRESS)
-          kernels_found.push_back(dyld);
+          kernels_found.push_back(kernel);
       }
     }
   }