exec: let cpu_watchpoint_insert accept larger watchpoints
authorMax Filippov <jcmvbkbc@gmail.com>
Sat, 28 Jan 2012 23:15:23 +0000 (03:15 +0400)
committerMax Filippov <jcmvbkbc@gmail.com>
Mon, 20 Feb 2012 16:07:11 +0000 (20:07 +0400)
Make cpu_watchpoint_insert accept watchpoints of any power-of-two size
up to the target page size.

Signed-off-by: Max Filippov <jcmvbkbc@gmail.com>
exec.c

diff --git a/exec.c b/exec.c
index ed091f3..80560fa 100644 (file)
--- a/exec.c
+++ b/exec.c
@@ -1443,7 +1443,8 @@ int cpu_watchpoint_insert(CPUState *env, target_ulong addr, target_ulong len,
     CPUWatchpoint *wp;
 
     /* sanity checks: allow power-of-2 lengths, deny unaligned watchpoints */
-    if ((len != 1 && len != 2 && len != 4 && len != 8) || (addr & ~len_mask)) {
+    if ((len & (len - 1)) || (addr & ~len_mask) ||
+            len == 0 || len > TARGET_PAGE_SIZE) {
         fprintf(stderr, "qemu: tried to set invalid watchpoint at "
                 TARGET_FMT_lx ", len=" TARGET_FMT_lu "\n", addr, len);
         return -EINVAL;