greybus: connection: fix potential null-deref on create

Make sure that the interface lookup helper can handle static,
bundle-less connections without oopsing when creating further
connections.

Note that the initial svc-connection has always been bundle-less, but
did not trigger an oops as a bundle was created for it before further
connections were created.

Signed-off-by: Johan Hovold <johan@hovoldconsulting.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@google.com>

diff --git a/drivers/staging/greybus/connection.c b/drivers/staging/greybus/connection.c
index d87a346..a7b8037 100644 (file)
--- a/drivers/staging/greybus/connection.c
+++ b/drivers/staging/greybus/connection.c
@@ -20,10 +20,12 @@ gb_connection_intf_find(struct gb_interface *intf, u16 cport_id)
        struct gb_host_device *hd = intf->hd;
        struct gb_connection *connection;
 
-       list_for_each_entry(connection, &hd->connections, hd_links)
-               if (connection->bundle->intf == intf &&
+       list_for_each_entry(connection, &hd->connections, hd_links) {
+               if (connection->intf == intf &&
                                connection->intf_cport_id == cport_id)
                        return connection;
+       }
+
        return NULL;
 }