drm/amd/pp: Add rv_copy_table_from/to_smc to smu backend function table

Reviewed-by: Alex Deucher <alexander.deucher@amd.com>
Signed-off-by: Rex Zhu <Rex.Zhu@amd.com>
Signed-off-by: Alex Deucher <alexander.deucher@amd.com>

diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
index 474612f2e86468ece61fb48611fc2d6160e4504b..4bdb28fd287a7e8ae7ea4f80a311a4aa3a63e866 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
+++ b/drivers/gpu/drm/amd/powerplay/hwmgr/rv_hwmgr.c
@@ -34,7 +34,6 @@
 #include "rv_ppsmc.h"
 #include "rv_hwmgr.h"
 #include "power_state.h"
-#include "rv_smumgr.h"
 #include "pp_soc15.h"
 
 #define RAVEN_MAX_DEEPSLEEP_DIVIDER_ID     5
@@ -347,7 +346,7 @@ static int rv_populate_clock_table(struct pp_hwmgr *hwmgr)
        DpmClocks_t  *table = &(rv_data->clock_table);
        struct rv_clock_voltage_information *pinfo = &(rv_data->clock_vol_info);
 
-       result = rv_copy_table_from_smc(hwmgr, (uint8_t *)table, CLOCKTABLE);
+       result = smum_smc_table_manager(hwmgr, (uint8_t *)table, SMU10_CLOCKTABLE, true);
 
        PP_ASSERT_WITH_CODE((0 == result),
                        "Attempt to copy clock table from smc failed",

diff --git a/drivers/gpu/drm/amd/powerplay/inc/smumgr.h b/drivers/gpu/drm/amd/powerplay/inc/smumgr.h
index c2199b8a1afb11da5d05d227dabab1f7f0333b9a..fc3a2a533586ea6f6fe9bb0d655c0ef528a99f54 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/inc/smumgr.h
+++ b/drivers/gpu/drm/amd/powerplay/inc/smumgr.h
@@ -69,6 +69,11 @@ enum SMU_MAC_DEFINITION {
        SMU_UVD_MCLK_HANDSHAKE_DISABLE,
 };
 
+enum SMU10_TABLE_ID {
+       SMU10_WMTABLE = 0,
+       SMU10_CLOCKTABLE,
+};
+
 extern int smum_get_argument(struct pp_hwmgr *hwmgr);
 
 extern int smum_download_powerplay_table(struct pp_hwmgr *hwmgr, void **table);

diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.c
index 867f0c1e202fdb39968d4be4d541b3364c7061f6..5dbef413b098cc87c40dec66f2bf881e2389061a 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.c
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.c
@@ -125,7 +125,7 @@ static int rv_send_msg_to_smc_with_parameter(struct pp_hwmgr *hwmgr,
        return 0;
 }
 
-int rv_copy_table_from_smc(struct pp_hwmgr *hwmgr,
+static int rv_copy_table_from_smc(struct pp_hwmgr *hwmgr,
                uint8_t *table, int16_t table_id)
 {
        struct rv_smumgr *priv =
@@ -153,7 +153,7 @@ int rv_copy_table_from_smc(struct pp_hwmgr *hwmgr,
        return 0;
 }
 
-int rv_copy_table_to_smc(struct pp_hwmgr *hwmgr,
+static int rv_copy_table_to_smc(struct pp_hwmgr *hwmgr,
                uint8_t *table, int16_t table_id)
 {
        struct rv_smumgr *priv =
@@ -232,12 +232,12 @@ static int rv_smu_fini(struct pp_hwmgr *hwmgr)
        if (priv) {
                rv_smc_disable_sdma(hwmgr);
                rv_smc_disable_vcn(hwmgr);
-               amdgpu_bo_free_kernel(&priv->smu_tables.entry[WMTABLE].handle,
-                                       &priv->smu_tables.entry[WMTABLE].mc_addr,
-                                       priv->smu_tables.entry[WMTABLE].table);
-               amdgpu_bo_free_kernel(&priv->smu_tables.entry[CLOCKTABLE].handle,
-                                       &priv->smu_tables.entry[CLOCKTABLE].mc_addr,
-                                       priv->smu_tables.entry[CLOCKTABLE].table);
+               amdgpu_bo_free_kernel(&priv->smu_tables.entry[SMU10_WMTABLE].handle,
+                                       &priv->smu_tables.entry[SMU10_WMTABLE].mc_addr,
+                                       priv->smu_tables.entry[SMU10_WMTABLE].table);
+               amdgpu_bo_free_kernel(&priv->smu_tables.entry[SMU10_CLOCKTABLE].handle,
+                                       &priv->smu_tables.entry[SMU10_CLOCKTABLE].mc_addr,
+                                       priv->smu_tables.entry[SMU10_CLOCKTABLE].table);
                kfree(hwmgr->smu_backend);
                hwmgr->smu_backend = NULL;
        }
@@ -279,45 +279,57 @@ static int rv_smu_init(struct pp_hwmgr *hwmgr)
                        sizeof(Watermarks_t),
                        PAGE_SIZE,
                        AMDGPU_GEM_DOMAIN_VRAM,
-                       &priv->smu_tables.entry[WMTABLE].handle,
-                       &priv->smu_tables.entry[WMTABLE].mc_addr,
-                       &priv->smu_tables.entry[WMTABLE].table);
+                       &priv->smu_tables.entry[SMU10_WMTABLE].handle,
+                       &priv->smu_tables.entry[SMU10_WMTABLE].mc_addr,
+                       &priv->smu_tables.entry[SMU10_WMTABLE].table);
 
        if (r)
                goto err0;
 
-       priv->smu_tables.entry[WMTABLE].version = 0x01;
-       priv->smu_tables.entry[WMTABLE].size = sizeof(Watermarks_t);
-       priv->smu_tables.entry[WMTABLE].table_id = TABLE_WATERMARKS;
-
+       priv->smu_tables.entry[SMU10_WMTABLE].version = 0x01;
+       priv->smu_tables.entry[SMU10_WMTABLE].size = sizeof(Watermarks_t);
+       priv->smu_tables.entry[SMU10_WMTABLE].table_id = TABLE_WATERMARKS;
 
        /* allocate space for watermarks table */
        r = amdgpu_bo_create_kernel((struct amdgpu_device *)hwmgr->adev,
                        sizeof(DpmClocks_t),
                        PAGE_SIZE,
                        AMDGPU_GEM_DOMAIN_VRAM,
-                       &priv->smu_tables.entry[CLOCKTABLE].handle,
-                       &priv->smu_tables.entry[CLOCKTABLE].mc_addr,
-                       &priv->smu_tables.entry[CLOCKTABLE].table);
+                       &priv->smu_tables.entry[SMU10_CLOCKTABLE].handle,
+                       &priv->smu_tables.entry[SMU10_CLOCKTABLE].mc_addr,
+                       &priv->smu_tables.entry[SMU10_CLOCKTABLE].table);
 
        if (r)
                goto err1;
 
-       priv->smu_tables.entry[CLOCKTABLE].version = 0x01;
-       priv->smu_tables.entry[CLOCKTABLE].size = sizeof(DpmClocks_t);
-       priv->smu_tables.entry[CLOCKTABLE].table_id = TABLE_DPMCLOCKS;
+       priv->smu_tables.entry[SMU10_CLOCKTABLE].version = 0x01;
+       priv->smu_tables.entry[SMU10_CLOCKTABLE].size = sizeof(DpmClocks_t);
+       priv->smu_tables.entry[SMU10_CLOCKTABLE].table_id = TABLE_DPMCLOCKS;
 
        return 0;
 
 err1:
-       amdgpu_bo_free_kernel(&priv->smu_tables.entry[WMTABLE].handle,
-                               &priv->smu_tables.entry[WMTABLE].mc_addr,
-                               &priv->smu_tables.entry[WMTABLE].table);
+       amdgpu_bo_free_kernel(&priv->smu_tables.entry[SMU10_WMTABLE].handle,
+                               &priv->smu_tables.entry[SMU10_WMTABLE].mc_addr,
+                               &priv->smu_tables.entry[SMU10_WMTABLE].table);
 err0:
        kfree(priv);
        return -EINVAL;
 }
 
+static int rv_smc_table_manager(struct pp_hwmgr *hwmgr, uint8_t *table, uint16_t table_id, bool rw)
+{
+       int ret;
+
+       if (rw)
+               ret = rv_copy_table_from_smc(hwmgr, table, table_id);
+       else
+               ret = rv_copy_table_to_smc(hwmgr, table, table_id);
+
+       return ret;
+}
+
+
 const struct pp_smumgr_func rv_smu_funcs = {
        .smu_init = &rv_smu_init,
        .smu_fini = &rv_smu_fini,
@@ -328,6 +340,7 @@ const struct pp_smumgr_func rv_smu_funcs = {
        .download_pptable_settings = NULL,
        .upload_pptable_settings = NULL,
        .get_argument = rv_read_arg_from_smc,
+       .smc_table_manager = rv_smc_table_manager,
 };
 
 

diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h b/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h
index a3bfdee9d8f7e9c8edc0f37e0ecefb0f3acca119..7b537981d0f6ba7308b1aaf3e09a22fee120ab9b 100644 (file)
--- a/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h
+++ b/drivers/gpu/drm/amd/powerplay/smumgr/rv_smumgr.h
@@ -27,11 +27,7 @@
 #include "rv_ppsmc.h"
 #include "smu10_driver_if.h"
 
-enum SMU_TABLE_ID {
-       WMTABLE = 0,
-       CLOCKTABLE,
-       MAX_SMU_TABLE,
-};
+#define MAX_SMU_TABLE 2
 
 struct smu_table_entry {
        uint32_t version;
@@ -50,10 +46,5 @@ struct rv_smumgr {
        struct smu_table_array            smu_tables;
 };
 
-int rv_copy_table_from_smc(struct pp_hwmgr *hwmgr,
-               uint8_t *table, int16_t table_id);
-int rv_copy_table_to_smc(struct pp_hwmgr *hwmgr,
-               uint8_t *table, int16_t table_id);
-
 
 #endif