staging: unisys: visorhba: viosrhba_main.c: Remove unnecessary checks
authorDavid Binder <david.binder@unisys.com>
Mon, 17 Jul 2017 20:16:48 +0000 (16:16 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Jul 2017 06:48:40 +0000 (08:48 +0200)
Removes unnecessary checks for a NULL pointer in a non-API function.

Signed-off-by: David Binder <david.binder@unisys.com>
Signed-off-by: David Kershner <david.kershner@unisys.com>
Reviewed-by: David Binder <david.binder@unisys.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/unisys/visorhba/visorhba_main.c

index 17468bf..1b4b338 100644 (file)
@@ -141,9 +141,6 @@ static struct task_struct *visor_thread_start
  */
 static void visor_thread_stop(struct task_struct *task)
 {
-       /* no thread running */
-       if (!task)
-               return;
        kthread_stop(task);
 }
 
@@ -829,7 +826,7 @@ do_scsi_linuxstat(struct uiscmdrsp *cmdrsp, struct scsi_cmnd *scsicmd)
 static int set_no_disk_inquiry_result(unsigned char *buf,
                                      size_t len, bool is_lun0)
 {
-       if (!buf || len < NO_DISK_INQUIRY_RESULT_LEN)
+       if (len < NO_DISK_INQUIRY_RESULT_LEN)
                return -EINVAL;
        memset(buf, 0, NO_DISK_INQUIRY_RESULT_LEN);
        buf[2] = SCSI_SPC2_VER;