net: wireless: rtl8723ds: Remove unnecessary null checks

The null check for an array element is not required because
it is always not null. Remove unnecessary null checks.

Change-Id: I1617511e7ae5b54ace2f62e8c8e2d486e5824449
Signed-off-by: Seung-Woo Kim <sw0312.kim@samsung.com>

diff --git a/drivers/net/wireless/rtl8723ds/hal/phydm/halrf/halrf.c b/drivers/net/wireless/rtl8723ds/hal/phydm/halrf/halrf.c
index b5af32477ca83d4e0e1131ff7f392ce23120f984..c311855aef9afaf84ec669b774b3d13dec55383e 100644 (file)
--- a/drivers/net/wireless/rtl8723ds/hal/phydm/halrf/halrf.c
+++ b/drivers/net/wireless/rtl8723ds/hal/phydm/halrf/halrf.c
@@ -820,8 +820,7 @@ void halrf_support_ability_debug(void *dm_void, char input[][16], u32 *_used,
        u8 i;
 
        for (i = 0; i < 5; i++)
-               if (input[i + 1])
-                       PHYDM_SSCANF(input[i + 2], DCMD_DECIMAL, &dm_value[i]);
+               PHYDM_SSCANF(input[i + 2], DCMD_DECIMAL, &dm_value[i]);
 
        if (dm_value[0] == 100) {
                PDM_SNPF(out_len, used, output + used, out_len - used,
@@ -4119,8 +4118,7 @@ void halrf_dump_rfk_reg(void *dm_void, char input[][16], u32 *_used,
 
        reg_1b00 = odm_get_bb_reg(dm, R_0x1b00, MASKDWORD);
 
-       if (input[2])
-               PHYDM_SSCANF(input[2], DCMD_DECIMAL, &var1[0]);
+       PHYDM_SSCANF(input[2], DCMD_DECIMAL, &var1[0]);
 
        if ((strcmp(input[2], help) == 0))
                PDM_SNPF(out_len, used, output + used, out_len - used,

diff --git a/drivers/net/wireless/rtl8723ds/hal/phydm/halrf/halrf_debug.c b/drivers/net/wireless/rtl8723ds/hal/phydm/halrf/halrf_debug.c
index 3f2d142b69217ca30ddfe2689ca2e501d230e1d8..efcb60579497bfe38758f0d2cb076c7935814b6c 100644 (file)
--- a/drivers/net/wireless/rtl8723ds/hal/phydm/halrf/halrf_debug.c
+++ b/drivers/net/wireless/rtl8723ds/hal/phydm/halrf/halrf_debug.c
@@ -151,8 +151,7 @@ void halrf_debug_trace(void *dm_void, char input[][16], u32 *_used,
        u8 i;
 
        for (i = 0; i < 5; i++)
-               if (input[i + 1])
-                       PHYDM_SSCANF(input[i + 2], DCMD_DECIMAL, &rf_var[i]);
+               PHYDM_SSCANF(input[i + 2], DCMD_DECIMAL, &rf_var[i]);
 
        if (rf_var[0] == 100) {
                PDM_SNPF(out_len, used, output + used, out_len - used,
@@ -211,8 +210,7 @@ void halrf_dack_debug_cmd(void *dm_void, char input[][16])
        u8 i;
 
        for (i = 0; i < 7; i++)
-               if (input[i + 1])
-                       PHYDM_SSCANF(input[i + 2], DCMD_DECIMAL, &dm_value[i]);
+               PHYDM_SSCANF(input[i + 2], DCMD_DECIMAL, &dm_value[i]);
 
        if (dm_value[0] == 1)
                halrf_dack_trigger(dm, true);
@@ -329,11 +327,8 @@ void halrf_cmd_parser(void *dm_void, char input[][16], u32 *_used, char *output,
                PDM_SNPF(out_len, used, output + used, out_len - used,
                         "IQK DEBUG!!!!!\n");
                for (i = 0; i < 5; i++) {
-                       if (input[i + 1]) {
-                               PHYDM_SSCANF(input[i + 2], DCMD_HEX,
-                                            &rf_var[i]);
-                               input_idx++;
-                       }
+                       PHYDM_SSCANF(input[i + 2], DCMD_HEX, &rf_var[i]);
+                       input_idx++;
                }
 
                if (input_idx >= 1) {

diff --git a/drivers/net/wireless/rtl8723ds/hal/phydm/phydm_pow_train.c b/drivers/net/wireless/rtl8723ds/hal/phydm/phydm_pow_train.c
index 56bc2411d2527f3692e6ad862d51753d57e08310..067cfdae068e67b23ed384ce07d1e05ecd96cdd1 100644 (file)
--- a/drivers/net/wireless/rtl8723ds/hal/phydm/phydm_pow_train.c
+++ b/drivers/net/wireless/rtl8723ds/hal/phydm/phydm_pow_train.c
@@ -149,8 +149,7 @@ void phydm_pow_train_debug(
                         "{0: Auto PT, 1:enable, 2: disable}\n");
        } else {
                for (i = 0; i < 10; i++) {
-                       if (input[i + 1])
-                               PHYDM_SSCANF(input[i + 1], DCMD_HEX, &var1[i]);
+                       PHYDM_SSCANF(input[i + 1], DCMD_HEX, &var1[i]);
                }
 
                if (var1[0] == 0)