staging: rtl8192e: Remove unused variables num_proc.., recei.. and rxov..
authorPhilipp Hortmann <philipp.g.hortmann@gmail.com>
Wed, 25 Jan 2023 20:08:59 +0000 (21:08 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 27 Jan 2023 09:12:04 +0000 (10:12 +0100)
num_process_phyinfo, received_bwtype and rxoverflow are initialized and
increased but never read. Remove dead code. As a result prxsc is unused
which in result makes rxsc_sgien_exflg unused. Remove prxsc and
rxsc_sgien_exflg as well.

Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: Philipp Hortmann <philipp.g.hortmann@gmail.com>
Link: https://lore.kernel.org/r/ff9daec237b795a01629080d0d5f7ec73b2d89da.1674675808.git.philipp.g.hortmann@gmail.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8192e/rtl8192e/r8192E_dev.c
drivers/staging/rtl8192e/rtl8192e/rtl_core.c
drivers/staging/rtl8192e/rtl8192e/rtl_core.h

index f62547e..9d13fda 100644 (file)
@@ -1296,9 +1296,8 @@ static void _rtl92e_query_rxphystatus(
 {
        struct phy_sts_ofdm_819xpci *pofdm_buf;
        struct phy_sts_cck_819xpci *pcck_buf;
-       struct phy_ofdm_rx_status_rxsc_sgien_exintfflag *prxsc;
        u8 *prxpkt;
-       u8 i, max_spatial_stream, tmp_rxsnr, tmp_rxevm, rxsc_sgien_exflg;
+       u8 i, max_spatial_stream, tmp_rxsnr, tmp_rxevm;
        s8 rx_pwr[4], rx_pwr_all = 0;
        s8 rx_snrX, rx_evmX;
        u8 evm, pwdb_all;
@@ -1464,15 +1463,6 @@ static void _rtl92e_query_rxphystatus(
                                precord_stats->RxMIMOSignalQuality[i] = evm & 0xff;
                        }
                }
-
-
-               rxsc_sgien_exflg = pofdm_buf->rxsc_sgien_exflg;
-               prxsc = (struct phy_ofdm_rx_status_rxsc_sgien_exintfflag *)
-                       &rxsc_sgien_exflg;
-               if (pdrvinfo->BW)
-                       priv->stats.received_bwtype[1+prxsc->rxsc]++;
-               else
-                       priv->stats.received_bwtype[0]++;
        }
 
        if (is_cck_rate) {
@@ -1535,7 +1525,6 @@ static void _rtl92e_process_phyinfo(struct r8192_priv *priv, u8 *buffer,
        if (!bcheck)
                return;
 
-       priv->stats.num_process_phyinfo++;
        if (!prev_st->bIsCCK && prev_st->bPacketToSelf) {
                for (rfpath = RF90_PATH_A; rfpath < RF90_PATH_C; rfpath++) {
                        if (!rtl92e_is_legal_rf_path(priv->rtllib->dev, rfpath))
index e0d0f4f..c5fe8e0 100644 (file)
@@ -2183,10 +2183,8 @@ static irqreturn_t _rtl92e_irq(int irq, void *netdev)
                tasklet_schedule(&priv->irq_rx_tasklet);
        }
 
-       if (inta & IMR_RXFOVW) {
-               priv->stats.rxoverflow++;
+       if (inta & IMR_RXFOVW)
                tasklet_schedule(&priv->irq_rx_tasklet);
-       }
 
        if (inta & IMR_TXFOVW)
                priv->stats.txoverflow++;
index e38de4d..bb94228 100644 (file)
@@ -184,9 +184,6 @@ enum reset_type {
 
 struct rt_stats {
        unsigned long received_rate_histogram[4][32];
-       unsigned long num_process_phyinfo;
-       unsigned long received_bwtype[5];
-       unsigned long rxoverflow;
        unsigned long rxint;
        unsigned long ints;
        unsigned long shints;