Use value_contents instead of value_contents_writeable

Both aarch64_push_dummy_call and bfin_push_dummy_call only use args[i]
contents but then never write to them, so that we can use
value_contents instead.

gdb:

2015-11-16  Yao Qi  <yao.qi@linaro.org>

	* aarch64-tdep.c (aarch64_push_dummy_call): Call value_contents instead
	of value_contents_writeable.
	* bfin-tdep.c (bfin_push_dummy_call): Likewise.

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 2b2409a..b445cec 100644 (file)
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,5 +1,11 @@
 2015-11-16  Yao Qi  <yao.qi@linaro.org>
 
+       * aarch64-tdep.c (aarch64_push_dummy_call): Call value_contents
+       instead of value_contents_writeable.
+       * bfin-tdep.c (bfin_push_dummy_call): Likewise.
+
+2015-11-16  Yao Qi  <yao.qi@linaro.org>
+
        * arm-tdep.c (arm_push_dummy_call): New array buf.  Store regval
        to buf.  Pass buf instead of val to push_stack_item.
 

diff --git a/gdb/aarch64-tdep.c b/gdb/aarch64-tdep.c
index bc282e9..553a420 100644 (file)
--- a/gdb/aarch64-tdep.c
+++ b/gdb/aarch64-tdep.c
@@ -1300,7 +1300,7 @@ aarch64_push_dummy_call (struct gdbarch *gdbarch, struct value *function,
                        check_typedef (value_type (field));
 
                      pass_in_v_or_stack (gdbarch, regcache, &info, field_type,
-                                         value_contents_writeable (field));
+                                         value_contents (field));
                    }
                }
              else

diff --git a/gdb/bfin-tdep.c b/gdb/bfin-tdep.c
index 1d48225..54936cc 100644 (file)
--- a/gdb/bfin-tdep.c
+++ b/gdb/bfin-tdep.c
@@ -531,7 +531,7 @@ bfin_push_dummy_call (struct gdbarch *gdbarch,
       int container_len = (TYPE_LENGTH (value_type) + 3) & ~3;
 
       sp -= container_len;
-      write_memory (sp, value_contents_writeable (args[i]), container_len);
+      write_memory (sp, value_contents (args[i]), container_len);
     }
 
   /* Initialize R0, R1, and R2 to the first 3 words of parameters.  */