staging: rtl8723bs: Replace zero-length array with flexible-array member
authorGustavo A. R. Silva <gustavoars@kernel.org>
Wed, 29 Sep 2021 19:41:18 +0000 (14:41 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 5 Oct 2021 10:28:06 +0000 (12:28 +0200)
One-element and zero-length arrays are deprecated and should be
replaced with flexible-array members[1].

Replace zero-length array with flexible-array member and make use
of the struct_size() helper.

[1] https://www.kernel.org/doc/html/v5.10/process/deprecated.html#zero-length-and-one-element-arrays

Link: https://github.com/KSPP/linux/issues/78
Link: https://github.com/KSPP/linux/issues/160
Signed-off-by: Gustavo A. R. Silva <gustavoars@kernel.org>
Link: https://lore.kernel.org/r/20210929194118.GA340431@embeddedor
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/rtl8723bs/include/osdep_service.h
drivers/staging/rtl8723bs/os_dep/osdep_service.c

index bde415d..cf96b5f 100644 (file)
@@ -113,7 +113,7 @@ struct rtw_cbuf {
        u32 write;
        u32 read;
        u32 size;
-       void *bufs[0];
+       void *bufs[];
 };
 
 bool rtw_cbuf_full(struct rtw_cbuf *cbuf);
index 2d630ec..d6bddf7 100644 (file)
@@ -274,7 +274,7 @@ struct rtw_cbuf *rtw_cbuf_alloc(u32 size)
 {
        struct rtw_cbuf *cbuf;
 
-       cbuf = rtw_malloc(sizeof(*cbuf) + sizeof(void *) * size);
+       cbuf = rtw_malloc(struct_size(cbuf, bufs, size));
 
        if (cbuf) {
                cbuf->write = cbuf->read = 0;