dummy: use IFF_LIVE_ADDR_CHANGE priv_flag
authorJiri Pirko <jpirko@redhat.com>
Fri, 29 Jun 2012 05:10:08 +0000 (05:10 +0000)
committerDavid S. Miller <davem@davemloft.net>
Sat, 30 Jun 2012 08:08:00 +0000 (01:08 -0700)
Signed-off-by: Jiri Pirko <jpirko@redhat.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/dummy.c

index bab0158..9d6a067 100644 (file)
 
 static int numdummies = 1;
 
-static int dummy_set_address(struct net_device *dev, void *p)
-{
-       struct sockaddr *sa = p;
-
-       if (!is_valid_ether_addr(sa->sa_data))
-               return -EADDRNOTAVAIL;
-
-       dev->addr_assign_type &= ~NET_ADDR_RANDOM;
-       memcpy(dev->dev_addr, sa->sa_data, ETH_ALEN);
-       return 0;
-}
-
 /* fake multicast ability */
 static void set_multicast_list(struct net_device *dev)
 {
@@ -118,7 +106,7 @@ static const struct net_device_ops dummy_netdev_ops = {
        .ndo_start_xmit         = dummy_xmit,
        .ndo_validate_addr      = eth_validate_addr,
        .ndo_set_rx_mode        = set_multicast_list,
-       .ndo_set_mac_address    = dummy_set_address,
+       .ndo_set_mac_address    = eth_mac_addr,
        .ndo_get_stats64        = dummy_get_stats64,
 };
 
@@ -134,6 +122,7 @@ static void dummy_setup(struct net_device *dev)
        dev->tx_queue_len = 0;
        dev->flags |= IFF_NOARP;
        dev->flags &= ~IFF_MULTICAST;
+       dev->priv_flags |= IFF_LIVE_ADDR_CHANGE;
        dev->features   |= NETIF_F_SG | NETIF_F_FRAGLIST | NETIF_F_TSO;
        dev->features   |= NETIF_F_HW_CSUM | NETIF_F_HIGHDMA | NETIF_F_LLTX;
        eth_hw_addr_random(dev);