perf: Fix lockdep_assert_event_ctx()
authorPeter Zijlstra <peterz@infradead.org>
Tue, 4 Oct 2022 08:46:58 +0000 (10:46 +0200)
committerPeter Zijlstra <peterz@infradead.org>
Tue, 4 Oct 2022 11:32:08 +0000 (13:32 +0200)
I'm a flamin' moron; because even after Mark told me it should be '&&'
I still got it wrong in the final commit.

Fixes: f3c0eba28704 ("perf: Add a few assertions")
Reported-by: Borislav Petkov <bp@alien8.de>
Reported-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
Tested-by: Borislav Petkov <bp@alien8.de>
Link: https://lkml.kernel.org/r/YvvIWmDBWdIUCMZj@FVFF77S0Q05N
include/linux/perf_event.h

index e9b151c..853f64b 100644 (file)
@@ -644,7 +644,7 @@ struct pmu_event_list {
 #ifdef CONFIG_PROVE_LOCKING
 #define lockdep_assert_event_ctx(event)                                \
        WARN_ON_ONCE(__lockdep_enabled &&                       \
-                    (this_cpu_read(hardirqs_enabled) ||        \
+                    (this_cpu_read(hardirqs_enabled) &&        \
                      lockdep_is_held(&(event)->ctx->mutex) != LOCK_STATE_HELD))
 #else
 #define lockdep_assert_event_ctx(event)