net: pc300too: replace comparison to NULL with "!card->plxbase"
authorPeng Li <lipeng321@huawei.com>
Fri, 11 Jun 2021 03:36:20 +0000 (11:36 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 11 Jun 2021 19:58:12 +0000 (12:58 -0700)
According to the chackpatch.pl, comparison to NULL could
be written "!card->plxbase".

Signed-off-by: Peng Li <lipeng321@huawei.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/wan/pc300too.c

index 56f7d96..ecce999 100644 (file)
@@ -298,7 +298,7 @@ static int pc300_pci_init_one(struct pci_dev *pdev,
        }
 
        card = kzalloc(sizeof(card_t), GFP_KERNEL);
-       if (card == NULL) {
+       if (!card) {
                pci_release_regions(pdev);
                pci_disable_device(pdev);
                return -ENOBUFS;
@@ -322,9 +322,7 @@ static int pc300_pci_init_one(struct pci_dev *pdev,
        ramphys = pci_resource_start(pdev, 3) & PCI_BASE_ADDRESS_MEM_MASK;
        card->rambase = pci_ioremap_bar(pdev, 3);
 
-       if (card->plxbase == NULL ||
-           card->scabase == NULL ||
-           card->rambase == NULL) {
+       if (!card->plxbase || !card->scabase || !card->rambase) {
                pr_err("ioremap() failed\n");
                pc300_pci_remove_one(pdev);
                return -ENOMEM;