spinner: fix mem leak on focus next traversel 23/117123/2
authorAmitesh Singh <amitesh.sh@samsung.com>
Mon, 23 Jan 2017 06:00:21 +0000 (11:30 +0530)
committerGerrit Code Review <gerrit@review.vlan103.tizen.org>
Tue, 7 Mar 2017 01:14:08 +0000 (17:14 -0800)
commit 9736dc6cf0606b4559b3202348511c974d4b2d99
Author: Amitesh Singh <amitesh.sh@samsung.com>
Date:   Mon Jan 23 11:23:22 2017 +0530

    spinner: fix mem leak on focus next traversel

    this patches fixes an eina list mem leak on each
    focus next(tab/alt-tab) traversal.

    @fix

Change-Id: Iff524f28db11cf23a69dacf03c58050e41d9f10b
Signed-off-by: Amitesh Singh <amitesh.sh@samsung.com>
src/lib/elm_spinner.c

index be40af7..8dcc4a2 100644 (file)
@@ -1525,6 +1525,7 @@ _elm_spinner_elm_widget_focus_next(Eo *obj, Elm_Spinner_Data *_pd, Elm_Focus_Dir
 {
    Evas_Object *ao;
    Eina_List *items = NULL;
+   int ret;
 
    ELM_SPINNER_CHECK(obj) EINA_FALSE;
 
@@ -1539,8 +1540,12 @@ _elm_spinner_elm_widget_focus_next(Eo *obj, Elm_Spinner_Data *_pd, Elm_Focus_Dir
         items = eina_list_append(items, _pd->text_button);
         items = eina_list_append(items, _pd->inc_button);
      }
-   return elm_widget_focus_list_next_get
+
+   ret = elm_widget_focus_list_next_get
             (obj, items, eina_list_data_get, dir, next, next_item);
+   eina_list_free(items);
+
+   return ret;
 }
 
 EOLIAN static void