net: hns3: Align type of some variables with their print type
authorHao Chen <chenhao288@hisilicon.com>
Fri, 3 Dec 2021 09:20:52 +0000 (17:20 +0800)
committerDavid S. Miller <davem@davemloft.net>
Fri, 3 Dec 2021 11:00:59 +0000 (11:00 +0000)
The c language has a set of implicit type conversions, when
two variables perform bitwise or arithmetic operations.

For example, variable A (type u16/u8) -1, its output is int type variable.
u16/u8 will convert to int type implicitly before it does arithmetic
operations. So, change 1 to unsigned type.

Signed-off-by: Hao Chen <chenhao288@hisilicon.com>
Signed-off-by: Guangbin Huang <huangguangbin2@huawei.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_debugfs.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_main.c
drivers/net/ethernet/hisilicon/hns3/hns3pf/hclge_mbx.c

index 6516812..1d039e1 100644 (file)
@@ -99,7 +99,7 @@ static void hclge_dbg_fill_content(char *content, u16 len,
 static char *hclge_dbg_get_func_id_str(char *buf, u8 id)
 {
        if (id)
-               sprintf(buf, "vf%u", id - 1);
+               sprintf(buf, "vf%u", id - 1U);
        else
                sprintf(buf, "pf");
 
index 2d12caa..e050e45 100644 (file)
@@ -6806,7 +6806,7 @@ static int hclge_fd_parse_ring_cookie(struct hclge_dev *hdev, u64 ring_cookie,
                if (vf > hdev->num_req_vfs) {
                        dev_err(&hdev->pdev->dev,
                                "Error: vf id (%u) should be less than %u\n",
-                               vf - 1, hdev->num_req_vfs);
+                               vf - 1U, hdev->num_req_vfs);
                        return -EINVAL;
                }
 
@@ -6816,7 +6816,7 @@ static int hclge_fd_parse_ring_cookie(struct hclge_dev *hdev, u64 ring_cookie,
                if (ring >= tqps) {
                        dev_err(&hdev->pdev->dev,
                                "Error: queue id (%u) > max tqp num (%u)\n",
-                               ring, tqps - 1);
+                               ring, tqps - 1U);
                        return -EINVAL;
                }
 
index c495df2..8b3954b 100644 (file)
@@ -181,7 +181,7 @@ static int hclge_get_ring_chain_from_mbx(
                if (req->msg.param[i].tqp_index >= vport->nic.kinfo.rss_size) {
                        dev_err(&hdev->pdev->dev, "tqp index(%u) is out of range(0-%u)\n",
                                req->msg.param[i].tqp_index,
-                               vport->nic.kinfo.rss_size - 1);
+                               vport->nic.kinfo.rss_size - 1U);
                        return -EINVAL;
                }
        }