gst/rtsp/rtspconnection.c: Don't set a data pointer to NULL and a size > 0 when we...

Original commit message from CVS:
* gst/rtsp/rtspconnection.c: (read_body):
Don't set a data pointer to NULL and a size > 0 when we deal
with empty packets.
* gst/rtsp/rtspmessage.c: (rtsp_message_new_response),
(rtsp_message_init_response), (rtsp_message_init_data),
(rtsp_message_unset), (rtsp_message_free),
(rtsp_message_take_body):
Check that we can't create invalid empty packets.

diff --git a/ChangeLog b/ChangeLog
index 4ca118c52754876cef39bf9b4aad404c73129dc5..3c75dd3695816364c8d6e79e74b36f2ad05808ae 100644 (file)
--- a/ChangeLog
+++ b/ChangeLog
@@ -1,3 +1,15 @@
+2006-11-15  Wim Taymans  <wim@fluendo.com>
+
+       * gst/rtsp/rtspconnection.c: (read_body):
+       Don't set a data pointer to NULL and a size > 0 when we deal
+       with empty packets.
+
+       * gst/rtsp/rtspmessage.c: (rtsp_message_new_response),
+       (rtsp_message_init_response), (rtsp_message_init_data),
+       (rtsp_message_unset), (rtsp_message_free),
+       (rtsp_message_take_body):
+       Check that we can't create invalid empty packets. 
+
 2006-11-15  Tim-Philipp Müller  <tim at centricular dot net>
 
        Patch by: Mark Nauwelaerts  <manauw at skynet be>

diff --git a/gst/rtsp/rtspconnection.c b/gst/rtsp/rtspconnection.c
index a0817f926b4d3db6ac7c8796cb07aee8c26dd6dd..848f502fb8f30c37e1fa9a97e1322ec7da980af3 100644 (file)
--- a/gst/rtsp/rtspconnection.c
+++ b/gst/rtsp/rtspconnection.c
@@ -588,8 +588,10 @@ read_body (RTSPConnection * conn, glong content_length, RTSPMessage * msg)
 
   RTSP_CHECK (rtsp_connection_read (conn, body, content_length), read_error);
 
+  content_length += 1;
+
 done:
-  rtsp_message_take_body (msg, (guint8 *) body, content_length + 1);
+  rtsp_message_take_body (msg, (guint8 *) body, content_length);
 
   return RTSP_OK;
 

diff --git a/gst/rtsp/rtspmessage.c b/gst/rtsp/rtspmessage.c
index 333661d093ff8a7bb1f7c787601d56dfd0498ef6..515ccb46ea72390f8cbd425238c48e3c59afdcfe 100644 (file)
--- a/gst/rtsp/rtspmessage.c
+++ b/gst/rtsp/rtspmessage.c
@@ -219,6 +219,7 @@ RTSPResult
 rtsp_message_take_body (RTSPMessage * msg, guint8 * data, guint size)
 {
   g_return_val_if_fail (msg != NULL, RTSP_EINVAL);
+  g_return_val_if_fail (data != NULL || size == 0, RTSP_EINVAL);
 
   if (msg->body)
     g_free (msg->body);