Debugger: correctly redirect eval code.
authoryangguo <yangguo@chromium.org>
Fri, 24 Jul 2015 14:14:10 +0000 (07:14 -0700)
committerCommit bot <commit-bot@chromium.org>
Fri, 24 Jul 2015 14:14:33 +0000 (14:14 +0000)
This also allows us to not always compile for debugging when debug is active.

Review URL: https://codereview.chromium.org/1258583002

Cr-Commit-Position: refs/heads/master@{#29848}

src/compiler.cc

index 861a34a..55415fe 100644 (file)
@@ -112,7 +112,6 @@ CompilationInfo::CompilationInfo(ParseInfo* parse_info)
   // with deoptimization support.
   if (isolate_->serializer_enabled()) EnableDeoptimizationSupport();
 
-  if (isolate_->debug()->is_active()) MarkAsDebug();
   if (FLAG_context_specialization) MarkAsContextSpecializing();
   if (FLAG_turbo_inlining) MarkAsInliningEnabled();
   if (FLAG_turbo_source_positions) MarkAsSourcePositionsEnabled();
@@ -1159,8 +1158,7 @@ MaybeHandle<JSFunction> Compiler::GetFunctionFromEval(
     parse_info.set_parse_restriction(restriction);
     parse_info.set_context(context);
 
-    // If we eval from debug code, compile for debugging as well.
-    if (outer_info->HasDebugCode()) info.MarkAsDebug();
+    info.MarkAsDebug();
     Debug::RecordEvalCaller(script);
 
     shared_info = CompileToplevel(&info);