etnaviv: Drop foreach_bit() macro
authorRob Clark <robdclark@chromium.org>
Mon, 22 Feb 2021 15:57:21 +0000 (07:57 -0800)
committerMarge Bot <eric+marge@anholt.net>
Wed, 24 Feb 2021 17:11:44 +0000 (17:11 +0000)
Now that we have a global one.

Signed-off-by: Rob Clark <robdclark@chromium.org>
Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz@gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9191>

src/gallium/drivers/etnaviv/etnaviv_context.c
src/gallium/drivers/etnaviv/etnaviv_util.h

index 90cd0ea..6589f03 100644 (file)
@@ -344,14 +344,14 @@ etna_draw_vbo(struct pipe_context *pctx, const struct pipe_draw_info *info,
    }
 
    /* Mark constant buffers as being read */
-   foreach_bit(i, ctx->constant_buffer[PIPE_SHADER_VERTEX].enabled_mask)
+   u_foreach_bit(i, ctx->constant_buffer[PIPE_SHADER_VERTEX].enabled_mask)
       resource_read(ctx, ctx->constant_buffer[PIPE_SHADER_VERTEX].cb[i].buffer);
 
-   foreach_bit(i, ctx->constant_buffer[PIPE_SHADER_FRAGMENT].enabled_mask)
+   u_foreach_bit(i, ctx->constant_buffer[PIPE_SHADER_FRAGMENT].enabled_mask)
       resource_read(ctx, ctx->constant_buffer[PIPE_SHADER_FRAGMENT].cb[i].buffer);
 
    /* Mark VBOs as being read */
-   foreach_bit(i, ctx->vertex_buffer.enabled_mask) {
+   u_foreach_bit(i, ctx->vertex_buffer.enabled_mask) {
       assert(!ctx->vertex_buffer.vb[i].is_user_buffer);
       resource_read(ctx, ctx->vertex_buffer.vb[i].buffer.resource);
    }
index d5b4dc9..43091d7 100644 (file)
@@ -30,9 +30,6 @@
 /* for conditionally setting boolean flag(s): */
 #define COND(bool, val) ((bool) ? (val) : 0)
 
-#define foreach_bit(b, mask) \
-   for (uint32_t _m = (mask); _m && ({(b) = u_bit_scan(&_m); 1;});)
-
 /* align to a value divisable by granularity >= value, works only for powers of two */
 static inline uint32_t
 etna_align_up(uint32_t value, uint32_t granularity)