projects
/
platform
/
kernel
/
linux-starfive.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(parent:
579a53c
)
powerpc: Fix error return in rtas_flash module init
author
Anton Blanchard
<anton@samba.org>
Mon, 14 Apr 2014 11:23:32 +0000
(21:23 +1000)
committer
Benjamin Herrenschmidt
<benh@kernel.crashing.org>
Mon, 28 Apr 2014 06:32:07 +0000
(16:32 +1000)
module_init should return 0 or a negative errno.
Signed-off-by: Anton Blanchard <anton@samba.org>
Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
arch/powerpc/kernel/rtas_flash.c
patch
|
blob
|
history
diff --git
a/arch/powerpc/kernel/rtas_flash.c
b/arch/powerpc/kernel/rtas_flash.c
index 2f3cdb01506de3d7791712ecd6ffeaf1fcd36352..658e89d2025b0b2dd65bb812d2c89d65867c1015 100644
(file)
--- a/
arch/powerpc/kernel/rtas_flash.c
+++ b/
arch/powerpc/kernel/rtas_flash.c
@@
-705,7
+705,7
@@
static int __init rtas_flash_init(void)
if (rtas_token("ibm,update-flash-64-and-reboot") ==
RTAS_UNKNOWN_SERVICE) {
pr_info("rtas_flash: no firmware flash support\n");
- return
1
;
+ return
-EINVAL
;
}
rtas_validate_flash_data.buf = kzalloc(VALIDATE_BUF_SIZE, GFP_KERNEL);