mfd: sec: Initialize driver via module_platform_driver()
authorKrzysztof Kozlowski <krzk@kernel.org>
Tue, 16 Mar 2021 13:25:15 +0000 (14:25 +0100)
committerLee Jones <lee.jones@linaro.org>
Wed, 14 Apr 2021 15:06:03 +0000 (16:06 +0100)
The driver was using subsys_initcall() because in old times deferred
probe was not supported everywhere and specific ordering was needed.
Since probe deferral works fine and specific ordering is discouraged
(hides dependencies between drivers and couples their boot order), the
driver can be converted to regular module_platform_driver.

Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Tested-by: Marek Szyprowski <m.szyprowski@samsung.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
drivers/mfd/sec-core.c

index 95473ff..8d55992 100644 (file)
@@ -549,19 +549,7 @@ static struct i2c_driver sec_pmic_driver = {
        .shutdown = sec_pmic_shutdown,
        .id_table = sec_pmic_id,
 };
-
-static int __init sec_pmic_init(void)
-{
-       return i2c_add_driver(&sec_pmic_driver);
-}
-
-subsys_initcall(sec_pmic_init);
-
-static void __exit sec_pmic_exit(void)
-{
-       i2c_del_driver(&sec_pmic_driver);
-}
-module_exit(sec_pmic_exit);
+module_i2c_driver(sec_pmic_driver);
 
 MODULE_AUTHOR("Sangbeom Kim <sbkim73@samsung.com>");
 MODULE_DESCRIPTION("Core support for the S5M MFD");