IVGCVSW-4731 Move Packet.hpp to profiling/common/include
authorFinn Williams <Finn.Williams@arm.com>
Thu, 7 May 2020 09:38:15 +0000 (10:38 +0100)
committerJim Flynn <jim.flynn@arm.com>
Tue, 12 May 2020 22:00:17 +0000 (22:00 +0000)
 * Refactor profiling cmake to fix inconsistencies/issues with includes

Signed-off-by: Finn Williams <Finn.Williams@arm.com>
Change-Id: I0836762d4c72e25754a28162ec54c8e332422a02

30 files changed:
Android.mk
CMakeLists.txt
profiling/common/include/Packet.hpp [moved from src/profiling/Packet.hpp with 100% similarity]
profiling/server/src/basePipeServer/BasePipeServer.hpp
profiling/server/src/basePipeServer/CMakeLists.txt
profiling/server/src/basePipeServer/tests/BasePipeServerTests.cpp
src/profiling/ActivateTimelineReportingCommandHandler.hpp
src/profiling/CommandHandlerFunctor.hpp
src/profiling/ConnectionAcknowledgedCommandHandler.hpp
src/profiling/DeactivateTimelineReportingCommandHandler.hpp
src/profiling/FileOnlyProfilingConnection.hpp
src/profiling/IProfilingConnection.hpp
src/profiling/PerJobCounterSelectionCommandHandler.hpp
src/profiling/PeriodicCounterCapture.hpp
src/profiling/PeriodicCounterSelectionCommandHandler.hpp
src/profiling/ProfilingUtils.hpp
src/profiling/RequestCounterDirectoryCommandHandler.hpp
src/profiling/test/PrintPacketHeaderHandler.hpp
src/profiling/test/TestTimelinePacketHandler.hpp
src/timelineDecoder/CMakeLists.txt
src/timelineDecoder/JSONTimelineDecoder.hpp
src/timelineDecoder/TimelineCaptureCommandHandler.hpp
src/timelineDecoder/TimelineDecoder.hpp
src/timelineDecoder/TimelineDirectoryCaptureCommandHandler.hpp
tests/profiling/gatordmock/CounterDirectory.hpp
tests/profiling/gatordmock/GatordMockMain.cpp
tests/profiling/gatordmock/GatordMockService.cpp
tests/profiling/gatordmock/PeriodicCounterSelectionResponseHandler.cpp
tests/profiling/gatordmock/StreamMetadataCommandHandler.cpp
tests/profiling/gatordmock/tests/GatordMockTests.cpp

index 99b1694..c9254c7 100644 (file)
@@ -10,6 +10,7 @@ OPENCL_HEADER_PATH := $(LOCAL_PATH)/../clframework/include
 NN_HEADER_PATH := $(LOCAL_PATH)/../../../../frameworks/ml/nn/runtime/include
 ARMNN_HEADER_PATH := $(LOCAL_PATH)/include
 ARMNN_PROFILING_INCLUDE_PATH := $(LOCAL_PATH)/profiling
+ARMNN_PROFILING_COMMON_INCLUDE_PATH := $(LOCAL_PATH)/profiling/common/include
 ARMNN_TIMELINE_DECODER_INCLUDE_PATH := $(LOCAL_PATH)/src/timelineDecoder
 ARMNN_MAIN_HEADER_PATH := $(LOCAL_PATH)/src
 ARMNN_SOURCE_HEADER_PATH := $(LOCAL_PATH)/src/armnn
@@ -67,6 +68,7 @@ LOCAL_EXPORT_C_INCLUDES := \
         $(ARMNN_MAIN_HEADER_PATH) \
         $(ARMNN_SOURCE_HEADER_PATH) \
         $(ARMNN_PROFILING_INCLUDE_PATH) \
+        $(ARMNN_PROFILING_COMMON_INCLUDE_PATH) \
         $(ARMNN_TIMELINE_DECODER_INCLUDE_PATH) \
         $(ARMNN_SOURCE_UTILS_HEADER_PATH) \
         $(ARMNN_PROFILING_HEADER_PATH) \
@@ -77,6 +79,7 @@ LOCAL_C_INCLUDES := \
         $(NN_HEADER_PATH) \
         $(ARMNN_HEADER_PATH) \
         $(ARMNN_PROFILING_INCLUDE_PATH) \
+        $(ARMNN_PROFILING_COMMON_INCLUDE_PATH) \
         $(ARMNN_TIMELINE_DECODER_INCLUDE_PATH) \
         $(ARMNN_MAIN_HEADER_PATH) \
         $(ARMNN_SOURCE_HEADER_PATH) \
@@ -305,6 +308,7 @@ LOCAL_C_INCLUDES := \
         $(NN_HEADER_PATH) \
         $(ARMNN_HEADER_PATH) \
         $(ARMNN_PROFILING_INCLUDE_PATH) \
+        $(ARMNN_PROFILING_COMMON_INCLUDE_PATH) \
         $(ARMNN_TIMELINE_DECODER_INCLUDE_PATH) \
         $(ARMNN_MAIN_HEADER_PATH) \
         $(ARMNN_SOURCE_HEADER_PATH) \
index eefa5e7..5f78a66 100644 (file)
@@ -250,6 +250,7 @@ list(APPEND armnn_sources
     include/armnn/utility/NumericCast.hpp
     include/armnn/utility/PolymorphicDowncast.hpp
     include/armnn/utility/StringUtils.hpp
+    profiling/common/include/Packet.hpp
     profiling/common/include/ProfilingException.hpp
     profiling/common/include/SocketConnectionException.hpp
     profiling/common/include/Constants.hpp
@@ -507,7 +508,6 @@ list(APPEND armnn_sources
     src/profiling/LabelsAndEventClasses.cpp
     src/profiling/LabelsAndEventClasses.hpp
     src/profiling/NullProfilingConnection.hpp
-    src/profiling/Packet.hpp
     src/profiling/PacketBuffer.cpp
     src/profiling/PacketBuffer.hpp
     src/profiling/PacketVersionResolver.cpp
@@ -921,7 +921,6 @@ if(BUILD_UNIT_TESTS)
     target_include_directories(UnitTests PRIVATE src/armnnUtils)
     target_include_directories(UnitTests PRIVATE src/backends)
     target_include_directories(UnitTests PRIVATE src/profiling)
-    target_include_directories(UnitTests PRIVATE src/timelineDecoder)
 
     if(VALGRIND_FOUND)
         if(HEAP_PROFILING OR LEAK_CHECKING)
@@ -1052,21 +1051,33 @@ if(BUILD_GATORD_MOCK)
         tests/profiling/gatordmock/StubCommandHandler.hpp
         )
 
-    include_directories(src/profiling src/timelineDecoder profiling/server/src/basePipeServer tests/profiling)
-
     add_library_ex(gatordMockService STATIC ${gatord_mock_sources})
-    target_include_directories(gatordMockService PRIVATE src/armnnUtils)
+
+    target_include_directories(gatordMockService PRIVATE profiling/common/include
+                                                         profiling/server/src/basePipeServer
+                                                         src/armnnUtils
+                                                         src/profiling
+                                                         src/timelineDecoder)
+
+    if(BUILD_UNIT_TESTS)
+        target_include_directories(UnitTests PRIVATE tests/profiling/gatordmock)
+        target_include_directories(UnitTests PRIVATE src/backends/backendsCommon/test)
+    endif()
 
     add_executable_ex(GatordMock tests/profiling/gatordmock/GatordMockMain.cpp)
-    target_include_directories(GatordMock PRIVATE src/armnnUtils)
+
+    target_include_directories(GatordMock PRIVATE profiling/common/include
+                                                  profiling/server/src/basePipeServer
+                                                  src/profiling
+                                                  src/timelineDecoder)
 
     target_link_libraries(GatordMock
-        armnn
-        armnnBasePipeServer
-        timelineDecoder
-        gatordMockService
-        ${Boost_PROGRAM_OPTIONS_LIBRARY}
-        ${Boost_SYSTEM_LIBRARY})
+                          armnn
+                          armnnBasePipeServer
+                          timelineDecoder
+                          gatordMockService
+                          ${Boost_PROGRAM_OPTIONS_LIBRARY}
+                          ${Boost_SYSTEM_LIBRARY})
 
     if(Threads_FOUND AND (NOT ("${CMAKE_SYSTEM_NAME}" STREQUAL Android)))
         target_link_libraries(GatordMock pthread)
index 4e6e0c0..bef9d29 100644 (file)
@@ -5,9 +5,9 @@
 
 #pragma once
 
-#include "common/include/NetworkSockets.hpp"
-#include "../../../../src/profiling/Packet.hpp"
-#include "common/include/SocketConnectionException.hpp"
+#include <NetworkSockets.hpp>
+#include <Packet.hpp>
+#include <SocketConnectionException.hpp>
 
 #include <string>
 #include <atomic>
index e535cf2..b2cb82d 100644 (file)
@@ -6,15 +6,20 @@
 if(BUILD_BASE_PIPE_SERVER)
     set(BasePipeServer_sources)
     list(APPEND BasePipeServer_sources
-            BasePipeServer.cpp
-            BasePipeServer.hpp
-            ConnectionHandler.cpp
-            ConnectionHandler.hpp
-            )
+        BasePipeServer.cpp
+        BasePipeServer.hpp
+        ConnectionHandler.cpp
+        ConnectionHandler.hpp)
 
-    include_directories(src/armnnUtils src/profiling)
+    include_directories(${PROJECT_SOURCE_DIR}/profiling/common/include)
+
+    if (BUILD_UNIT_TESTS)
+        target_include_directories(UnitTests PRIVATE ${PROJECT_SOURCE_DIR}/profiling/server/src/basePipeServer)
+        target_include_directories(UnitTests PUBLIC ${PROJECT_SOURCE_DIR}/profiling/common/include)
+    endif()
 
     add_library_ex(armnnBasePipeServer SHARED ${BasePipeServer_sources})
+
     set_target_properties(armnnBasePipeServer PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR})
     set_target_properties(armnnBasePipeServer PROPERTIES VERSION ${GENERIC_LIB_VERSION}
                           SOVERSION ${GENERIC_LIB_SOVERSION})
index c85bbe7..c97fecd 100644 (file)
@@ -3,7 +3,7 @@
 // SPDX-License-Identifier: MIT
 //
 
-#include "../ConnectionHandler.hpp"
+#include <ConnectionHandler.hpp>
 
 #include <SocketProfilingConnection.hpp>
 #include <Processes.hpp>
index ac11b46..a0a2de0 100644 (file)
@@ -7,12 +7,15 @@
 
 #include "CommandHandlerFunctor.hpp"
 #include "ProfilingStateMachine.hpp"
-#include "Packet.hpp"
 #include "SendTimelinePacket.hpp"
 #include "IReportStructure.hpp"
-#include "armnn/Optional.hpp"
 #include "INotifyBackends.hpp"
 
+#include "armnn/Optional.hpp"
+
+#include "common/include/Packet.hpp"
+
+
 namespace armnn
 {
 
index 743bb93..8096c41 100644 (file)
@@ -5,7 +5,7 @@
 
 #pragma once
 
-#include "Packet.hpp"
+#include "common/include/Packet.hpp"
 
 #include <armnn/utility/IgnoreUnused.hpp>
 
index 053d3c3..bcd1eed 100644 (file)
@@ -9,9 +9,8 @@
 #include "CommandHandlerFunctor.hpp"
 #include "ISendCounterPacket.hpp"
 #include "armnn/profiling/ISendTimelinePacket.hpp"
-#include "Packet.hpp"
+#include "common/include/Packet.hpp"
 #include "ProfilingStateMachine.hpp"
-#include <future>
 
 namespace armnn
 {
index e06bae8..e9ce63d 100644 (file)
@@ -6,7 +6,7 @@
 #pragma once
 
 #include "CommandHandlerFunctor.hpp"
-#include "Packet.hpp"
+#include "common/include/Packet.hpp"
 #include "ProfilingStateMachine.hpp"
 #include "INotifyBackends.hpp"
 
index 466f4f1..75db477 100644 (file)
@@ -8,7 +8,7 @@
 #include <armnn/profiling/ILocalPacketHandler.hpp>
 #include "DirectoryCaptureCommandHandler.hpp"
 #include "IProfilingConnection.hpp"
-#include "Packet.hpp"
+#include "common/include/Packet.hpp"
 #include "ProfilingUtils.hpp"
 #include "Runtime.hpp"
 
index 2a1c35f..2fc950e 100644 (file)
@@ -5,7 +5,7 @@
 
 #pragma once
 
-#include "Packet.hpp"
+#include "common/include/Packet.hpp"
 #include <armnn/profiling/ILocalPacketHandler.hpp>
 
 #include <cstdint>
index 738a476..16cb02a 100644 (file)
@@ -5,7 +5,7 @@
 
 #pragma once
 
-#include "Packet.hpp"
+#include "common/include/Packet.hpp"
 #include "CommandHandlerFunctor.hpp"
 #include "ProfilingStateMachine.hpp"
 
index 51ac273..796c494 100644 (file)
@@ -7,7 +7,7 @@
 
 #include "IPeriodicCounterCapture.hpp"
 #include "Holder.hpp"
-#include "Packet.hpp"
+#include "common/include/Packet.hpp"
 #include "SendCounterPacket.hpp"
 #include "ICounterValues.hpp"
 #include "CounterIdMap.hpp"
index b59d84c..8cf5595 100644 (file)
@@ -6,7 +6,7 @@
 #pragma once
 
 #include "CounterIdMap.hpp"
-#include "Packet.hpp"
+#include "common/include/Packet.hpp"
 #include "CommandHandlerFunctor.hpp"
 #include "Holder.hpp"
 #include "ProfilingStateMachine.hpp"
index e2ffb24..127534a 100644 (file)
@@ -10,7 +10,8 @@
 
 #include "ICounterDirectory.hpp"
 #include "IPacketBuffer.hpp"
-#include "Packet.hpp"
+
+#include "common/include/Packet.hpp"
 
 #include <boost/numeric/conversion/cast.hpp>
 
index 9ceca3f..ea60ca8 100644 (file)
@@ -8,7 +8,7 @@
 #include "CommandHandlerFunctor.hpp"
 #include "ISendCounterPacket.hpp"
 #include "armnn/profiling/ISendTimelinePacket.hpp"
-#include "Packet.hpp"
+#include "common/include/Packet.hpp"
 #include "ProfilingStateMachine.hpp"
 
 namespace armnn
index 3cd5921..6564f3c 100644 (file)
@@ -6,7 +6,7 @@
 #pragma once
 
 #include <armnn/profiling/ILocalPacketHandler.hpp>
-#include "Packet.hpp"
+#include <Packet.hpp>
 
 namespace armnn
 {
index 2902e5f..6739525 100644 (file)
@@ -7,7 +7,8 @@
 
 #include <armnn/profiling/ILocalPacketHandler.hpp>
 #include <armnn/profiling/ITimelineDecoder.hpp>
-#include "Packet.hpp"
+#include <Packet.hpp>
+
 #include "ProfilingUtils.hpp"
 #include "TimelineCaptureCommandHandler.hpp"
 #include "TimelineDirectoryCaptureCommandHandler.hpp"
index 12fe2a0..f844325 100644 (file)
@@ -6,20 +6,25 @@
 if(BUILD_TIMELINE_DECODER)
     set(timelineDecoder_sources)
     list(APPEND timelineDecoder_sources
-            ../../include/armnn/profiling/ITimelineDecoder.hpp
-            TimelineCaptureCommandHandler.cpp
-            TimelineCaptureCommandHandler.hpp
-            JSONTimelineDecoder.cpp
-            JSONTimelineDecoder.hpp
-            TimelineDecoder.cpp
-            TimelineDecoder.hpp
-            TimelineDirectoryCaptureCommandHandler.cpp
-            TimelineDirectoryCaptureCommandHandler.hpp
-            )
-
-    include_directories(../timelineDecoder ../profiling)
+        ${PROJECT_SOURCE_DIR}/include/armnn/profiling/ITimelineDecoder.hpp
+        TimelineCaptureCommandHandler.cpp
+        TimelineCaptureCommandHandler.hpp
+        JSONTimelineDecoder.cpp
+        JSONTimelineDecoder.hpp
+        TimelineDecoder.cpp
+        TimelineDecoder.hpp
+        TimelineDirectoryCaptureCommandHandler.cpp
+        TimelineDirectoryCaptureCommandHandler.hpp)
+
+    include_directories(${PROJECT_SOURCE_DIR}/src/profiling
+                        ${PROJECT_SOURCE_DIR}/profiling/common/include)
+
+    if(BUILD_UNIT_TESTS)
+      target_include_directories(UnitTests PRIVATE ${PROJECT_SOURCE_DIR}/src/timelineDecoder)
+    endif()
 
     add_library_ex(timelineDecoder SHARED ${timelineDecoder_sources})
+
     set_target_properties(timelineDecoder PROPERTIES LIBRARY_OUTPUT_DIRECTORY ${PROJECT_BINARY_DIR})
     set_target_properties(timelineDecoder PROPERTIES VERSION ${GENERIC_LIB_VERSION} SOVERSION ${GENERIC_LIB_SOVERSION} )
 
index c4e0855..38d6983 100644 (file)
@@ -5,7 +5,7 @@
 
 #pragma once
 
-#include "armnn/profiling/ITimelineDecoder.hpp"
+#include <armnn/profiling/ITimelineDecoder.hpp>
 
 #include <map>
 #include <vector>
index e143b5f..6c0c57a 100644 (file)
@@ -5,7 +5,7 @@
 
 #pragma once
 
-#include "armnn/profiling/ITimelineDecoder.hpp"
+#include <armnn/profiling/ITimelineDecoder.hpp>
 
 #include <CommandHandlerFunctor.hpp>
 #include <Packet.hpp>
index c6d1e4e..2efdc44 100644 (file)
@@ -4,7 +4,8 @@
 //
 #pragma once
 
-#include "armnn/profiling/ITimelineDecoder.hpp"
+#include <armnn/profiling/ITimelineDecoder.hpp>
+
 #include <vector>
 
 namespace armnn
index a22a5d9..2879052 100644 (file)
@@ -5,8 +5,8 @@
 
 #pragma once
 
+#include "TimelineCaptureCommandHandler.hpp"
 
-#include <TimelineCaptureCommandHandler.hpp>
 #include <Packet.hpp>
 #include <PacketBuffer.hpp>
 #include <ProfilingUtils.hpp>
index 528c037..31718dd 100644 (file)
@@ -9,7 +9,7 @@
 #include "GatordMockService.hpp"
 #include "MockUtils.hpp"
 
-#include "Packet.hpp"
+#include <Packet.hpp>
 #include "CommandHandlerFunctor.hpp"
 #include "SendCounterPacket.hpp"
 #include "IPeriodicCounterCapture.hpp"
index 0dbddeb..5d6e886 100644 (file)
@@ -5,9 +5,10 @@
 
 #include "CommandFileParser.hpp"
 #include "CommandLineProcessor.hpp"
-#include <ConnectionHandler.hpp>
 #include "GatordMockService.hpp"
 
+#include <ConnectionHandler.hpp>
+
 #include <string>
 #include <signal.h>
 
index 53974fe..13f6882 100644 (file)
@@ -8,7 +8,7 @@
 #include <CommandHandlerRegistry.hpp>
 #include <PacketVersionResolver.hpp>
 #include <ProfilingUtils.hpp>
-#include <common/include/NetworkSockets.hpp>
+#include <NetworkSockets.hpp>
 
 #include <armnn/utility/Assert.hpp>
 
index 645b0b3..2c2e711 100644 (file)
@@ -5,7 +5,7 @@
 
 #include "PeriodicCounterSelectionResponseHandler.hpp"
 
-#include "../../../src/profiling/ProfilingUtils.hpp"
+#include <ProfilingUtils.hpp>
 
 #include <iostream>
 
index 09255a5..d97925c 100644 (file)
@@ -7,9 +7,6 @@
 
 #include <ProfilingUtils.hpp>
 
-#include <boost/cast.hpp>
-
-#include <sstream>
 #include <iostream>
 
 using namespace armnn::profiling;
index cdedeeb..98ca8ff 100644 (file)
@@ -6,7 +6,7 @@
 #include <CommandHandlerRegistry.hpp>
 #include <ConnectionHandler.hpp>
 #include <DirectoryCaptureCommandHandler.hpp>
-#include <gatordmock/GatordMockService.hpp>
+#include <GatordMockService.hpp>
 #include <LabelsAndEventClasses.hpp>
 #include <ProfilingService.hpp>
 #include <TimelinePacketWriterFactory.hpp>
@@ -15,7 +15,8 @@
 #include <TimelineDecoder.hpp>
 
 #include <Runtime.hpp>
-#include "../../src/backends/backendsCommon/test/MockBackend.hpp"
+
+#include <MockBackend.hpp>
 
 #include <boost/cast.hpp>
 #include <boost/test/test_tools.hpp>