media: platform: sti: make a const arrays static, makes object smaller
authorColin Ian King <colin.king@canonical.com>
Thu, 4 Feb 2021 17:08:50 +0000 (18:08 +0100)
committerMauro Carvalho Chehab <mchehab+huawei@kernel.org>
Thu, 11 Mar 2021 10:59:42 +0000 (11:59 +0100)
Don't populate the const arrays on the stack but instead it
static. Makes the object code smaller by 8 bytes:

Before:
   text    data     bss     dec     hex filename
  12504    4568       0   17072    42b0 media/platform/sti/hva/hva-h264.o

After:
   text    data     bss     dec     hex filename
  12272    4792       0   17064    42a8 media/platform/sti/hva/hva-h264.o

(gcc version 10.2.0)

Signed-off-by: Colin Ian King <colin.king@canonical.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
drivers/media/platform/sti/hva/hva-h264.c

index c34f7cf..98cb00d 100644 (file)
@@ -428,8 +428,10 @@ static int hva_h264_fill_slice_header(struct hva_ctx *pctx,
         */
        struct device *dev = ctx_to_dev(pctx);
        int  cabac = V4L2_MPEG_VIDEO_H264_ENTROPY_MODE_CABAC;
-       const unsigned char slice_header[] = { 0x00, 0x00, 0x00, 0x01,
-                                              0x41, 0x34, 0x07, 0x00};
+       static const unsigned char slice_header[] = {
+               0x00, 0x00, 0x00, 0x01,
+               0x41, 0x34, 0x07, 0x00
+       };
        int idr_pic_id = frame_num % 2;
        enum hva_picture_coding_type type;
        u32 frame_order = frame_num % ctrls->gop_size;
@@ -488,7 +490,7 @@ static int hva_h264_fill_data_nal(struct hva_ctx *pctx,
                                  unsigned int stream_size, unsigned int *size)
 {
        struct device *dev = ctx_to_dev(pctx);
-       const u8 start[] = { 0x00, 0x00, 0x00, 0x01 };
+       static const u8 start[] = { 0x00, 0x00, 0x00, 0x01 };
 
        dev_dbg(dev, "%s   %s stuffing bytes %d\n", pctx->name, __func__,
                stuffing_bytes);
@@ -521,7 +523,7 @@ static int hva_h264_fill_sei_nal(struct hva_ctx *pctx,
                                 u8 *addr, u32 *size)
 {
        struct device *dev = ctx_to_dev(pctx);
-       const u8 start[] = { 0x00, 0x00, 0x00, 0x01 };
+       static const u8 start[] = { 0x00, 0x00, 0x00, 0x01 };
        struct hva_h264_stereo_video_sei info;
        u8 offset = 7;
        u8 msg = 0;