net: Simplify the calculation of variables
authorJiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Mon, 25 Jan 2021 06:41:46 +0000 (14:41 +0800)
committerSteffen Klassert <steffen.klassert@secunet.com>
Wed, 27 Jan 2021 10:49:55 +0000 (11:49 +0100)
Fix the following coccicheck warnings:

 ./net/ipv4/esp4_offload.c:288:32-34: WARNING !A || A && B is
equivalent to !A || B.

Reported-by: Abaci Robot <abaci@linux.alibaba.com>
Signed-off-by: Jiapeng Zhong <abaci-bugfix@linux.alibaba.com>
Signed-off-by: Steffen Klassert <steffen.klassert@secunet.com>
net/ipv4/esp4_offload.c

index 5bda5ae..601f5fb 100644 (file)
@@ -285,7 +285,7 @@ static int esp_xmit(struct xfrm_state *x, struct sk_buff *skb,  netdev_features_
        esp.esph = ip_esp_hdr(skb);
 
 
-       if (!hw_offload || (hw_offload && !skb_is_gso(skb))) {
+       if (!hw_offload || !skb_is_gso(skb)) {
                esp.nfrags = esp_output_head(x, skb, &esp);
                if (esp.nfrags < 0)
                        return esp.nfrags;