drm/i915/dsi: fix MIPI_BKLT_EN_1 native GPIO index
authorJani Nikula <jani.nikula@intel.com>
Tue, 20 Dec 2022 14:01:05 +0000 (16:01 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 12 Jan 2023 11:02:58 +0000 (12:02 +0100)
commit 6217e9f05a74df48c77ee68993d587cdfdb1feb7 upstream.

Due to copy-paste fail, MIPI_BKLT_EN_1 would always use PPS index 1,
never 0. Fix the sloppiest commit in recent memory.

Fixes: 963bbdb32b47 ("drm/i915/dsi: add support for ICL+ native MIPI GPIO sequence")
Reported-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20221220140105.313333-1-jani.nikula@intel.com
(cherry picked from commit a561933c571798868b5fa42198427a7e6df56c09)
Cc: stable@vger.kernel.org # 6.1
Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/gpu/drm/i915/display/intel_dsi_vbt.c

index 41f025f..2cbc129 100644 (file)
@@ -430,7 +430,7 @@ static void icl_native_gpio_set_value(struct drm_i915_private *dev_priv,
                break;
        case MIPI_BKLT_EN_1:
        case MIPI_BKLT_EN_2:
-               index = gpio == MIPI_AVDD_EN_1 ? 0 : 1;
+               index = gpio == MIPI_BKLT_EN_1 ? 0 : 1;
 
                intel_de_rmw(dev_priv, PP_CONTROL(index), EDP_BLC_ENABLE,
                             value ? EDP_BLC_ENABLE : 0);