ASoC: SOF: loader: do not warn about unknown firmware headers
authorKai Vehmanen <kai.vehmanen@linux.intel.com>
Wed, 11 Nov 2020 17:33:21 +0000 (19:33 +0200)
committerMark Brown <broonie@kernel.org>
Thu, 12 Nov 2020 15:15:56 +0000 (15:15 +0000)
The firmware extended data IPC and manifest structures are designed to
be extendable without breaking the driver-firmware ABI. Driver should
not raise a warning in case a new header type is detected at
firmware boot. There are already checks for IPC ABI compatibility in
snd_sof_ipc_valid() and if the versions are deemed compatible, extra
fields in IPC messages should not trigger warnings.

Signed-off-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
Reviewed-by: Karol TrzciƄski <karolx.trzcinski@linux.intel.com>
Link: https://lore.kernel.org/r/20201111173321.1933452-1-kai.vehmanen@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org>
sound/soc/sof/loader.c

index ba9ed66..ce68d70 100644 (file)
@@ -124,7 +124,7 @@ int snd_sof_fw_parse_ext_data(struct snd_sof_dev *sdev, u32 bar, u32 offset)
                        /* They are supported but we don't do anything here */
                        break;
                default:
-                       dev_warn(sdev->dev, "warning: unknown ext header type %d size 0x%x\n",
+                       dev_info(sdev->dev, "unknown ext header type %d size 0x%x\n",
                                 ext_hdr->type, ext_hdr->hdr.size);
                        ret = 0;
                        break;
@@ -280,7 +280,7 @@ static int snd_sof_fw_ext_man_parse(struct snd_sof_dev *sdev,
                        ret = ext_man_get_dbg_abi_info(sdev, elem_hdr);
                        break;
                default:
-                       dev_warn(sdev->dev, "warning: unknown sof_ext_man header type %d size 0x%X\n",
+                       dev_info(sdev->dev, "unknown sof_ext_man header type %d size 0x%X\n",
                                 elem_hdr->type, elem_hdr->size);
                        break;
                }