infiniband: nes: Use skb_peek_next() and skb_queue_walk().
authorDavid S. Miller <davem@davemloft.net>
Sun, 5 Aug 2018 19:57:30 +0000 (12:57 -0700)
committerDavid S. Miller <davem@davemloft.net>
Mon, 10 Sep 2018 17:06:53 +0000 (10:06 -0700)
Instead of direct SKB list accesses.

Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/infiniband/hw/nes/nes_mgt.c

index 9bdb84dc225cfe9763541f271ccfdabd42e77716..e96ffff61c3a631179baad3afaa710fcd5c6d6de 100644 (file)
@@ -198,9 +198,9 @@ static struct sk_buff *nes_get_next_skb(struct nes_device *nesdev, struct nes_qp
 
        if (skb) {
                /* Continue processing fpdu */
-               if (skb->next == (struct sk_buff *)&nesqp->pau_list)
+               skb = skb_peek_next(skb, &nesqp->pau_list);
+               if (!skb)
                        goto out;
-               skb = skb->next;
                processacks = false;
        } else {
                /* Starting a new one */
@@ -553,12 +553,10 @@ static void queue_fpdus(struct sk_buff *skb, struct nes_vnic *nesvnic, struct ne
        if (skb_queue_len(&nesqp->pau_list) == 0) {
                skb_queue_head(&nesqp->pau_list, skb);
        } else {
-               tmpskb = nesqp->pau_list.next;
-               while (tmpskb != (struct sk_buff *)&nesqp->pau_list) {
+               skb_queue_walk(&nesqp->pau_list, tmpskb) {
                        cb = (struct nes_rskb_cb *)&tmpskb->cb[0];
                        if (before(seqnum, cb->seqnum))
                                break;
-                       tmpskb = tmpskb->next;
                }
                skb_insert(tmpskb, skb, &nesqp->pau_list);
        }