RISC-V: avoid splitting small constant in <or_optab>i<mode>_extrabit pattern
authorLin Sinan <mynameisxiaou@gmail.com>
Tue, 11 Apr 2023 16:23:19 +0000 (10:23 -0600)
committerJeff Law <jlaw@ventanamicro>
Tue, 11 Apr 2023 16:26:59 +0000 (10:26 -0600)
there is no need to split an xori/ori with an small constant. take the test
case `int foo(int idx) { return idx|3; }` as an example,

rv64im_zba generates:
        ori     a0,a0,3
        ret
but, rv64im_zba_zbs generates:
        ori     a0,a0,1
        ori     a0,a0,2
        ret

with this change, insn `ori r2,r1,3` will not be splitted in zbs.

gcc/
* config/riscv/predicates.md (uimm_extra_bit_or_twobits): Adjust
predicate to avoid splitting arith constants.

gcc/testsuite

* gcc.target/riscv/zbs-extra-bit-or-twobits.c: New test.

gcc/config/riscv/predicates.md
gcc/testsuite/gcc.target/riscv/zbs-extra-bit-or-twobits.c [new file with mode: 0644]

index 0d9d770..8654dbc 100644 (file)
 (define_predicate "uimm_extra_bit_or_twobits"
   (and (match_code "const_int")
        (ior (match_operand 0 "uimm_extra_bit_operand")
-           (match_operand 0 "const_twobits_operand"))))
+           (match_operand 0 "const_twobits_not_arith_operand"))))
 
 ;; A CONST_INT operand that fits into the negative half of a
 ;; signed-immediate after a single cleared top bit has been
diff --git a/gcc/testsuite/gcc.target/riscv/zbs-extra-bit-or-twobits.c b/gcc/testsuite/gcc.target/riscv/zbs-extra-bit-or-twobits.c
new file mode 100644 (file)
index 0000000..ef7ed60
--- /dev/null
@@ -0,0 +1,14 @@
+/* { dg-do compile } */
+/* { dg-options "-march=rv64gc_zbs -mabi=lp64" } */
+/* { dg-skip-if "" { *-*-* } { "-O0" "-Og" } } */
+
+int or_two_bit(int idx) {
+    return idx|3;
+}
+
+int xor_two_bit(int idx) {
+    return idx^3;
+}
+
+/* { dg-final { scan-assembler-times "\tori\t" 1 } } */
+/* { dg-final { scan-assembler-times "\txori\t" 1 } } */