ALSA: hda: Always free codec on the device release
authorCezary Rojewski <cezary.rojewski@intel.com>
Tue, 16 Aug 2022 11:17:25 +0000 (13:17 +0200)
committerTakashi Iwai <tiwai@suse.de>
Thu, 18 Aug 2022 07:46:58 +0000 (09:46 +0200)
With all HDAudio drivers aligned to make use of the same constructor,
have codec freed on the device release regardless of its type.

Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: Cezary Rojewski <cezary.rojewski@intel.com>
Link: https://lore.kernel.org/r/20220816111727.3218543-5-cezary.rojewski@intel.com
Signed-off-by: Takashi Iwai <tiwai@suse.de>
sound/pci/hda/hda_codec.c

index 384426d..aa7a362 100644 (file)
@@ -883,13 +883,7 @@ static void snd_hda_codec_dev_release(struct device *dev)
        snd_hda_sysfs_clear(codec);
        kfree(codec->modelname);
        kfree(codec->wcaps);
-
-       /*
-        * In the case of ASoC HD-audio, hda_codec is device managed.
-        * It will be freed when the ASoC device is removed.
-        */
-       if (codec->core.type == HDA_DEV_LEGACY)
-               kfree(codec);
+       kfree(codec);
 }
 
 #define DEV_NAME_LEN 31