wifi: p54: Use the bitmap API to allocate bitmaps
authorChristophe JAILLET <christophe.jaillet@wanadoo.fr>
Mon, 4 Jul 2022 13:02:55 +0000 (15:02 +0200)
committerKalle Valo <kvalo@kernel.org>
Mon, 18 Jul 2022 11:51:54 +0000 (14:51 +0300)
Use bitmap_zalloc()/bitmap_free() instead of hand-writing them.

It is less verbose and it improves the semantic.

Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Acked-by: Christian Lamparter <chunkeey@gmail.com>
Signed-off-by: Kalle Valo <kvalo@kernel.org>
Link: https://lore.kernel.org/r/2755b8b7d85a2db0663d39ea6df823f94f3401b3.1656939750.git.christophe.jaillet@wanadoo.fr
drivers/net/wireless/intersil/p54/fwio.c
drivers/net/wireless/intersil/p54/main.c

index bece14e..b52cce3 100644 (file)
@@ -173,10 +173,8 @@ int p54_parse_firmware(struct ieee80211_hw *dev, const struct firmware *fw)
                 * keeping a extra list for uploaded keys.
                 */
 
-               priv->used_rxkeys = kcalloc(BITS_TO_LONGS(priv->rx_keycache_size),
-                                           sizeof(long),
-                                           GFP_KERNEL);
-
+               priv->used_rxkeys = bitmap_zalloc(priv->rx_keycache_size,
+                                                 GFP_KERNEL);
                if (!priv->used_rxkeys)
                        return -ENOMEM;
        }
index 0f76d43..26b28d4 100644 (file)
@@ -831,7 +831,7 @@ void p54_free_common(struct ieee80211_hw *dev)
        kfree(priv->output_limit);
        kfree(priv->curve_data);
        kfree(priv->rssi_db);
-       kfree(priv->used_rxkeys);
+       bitmap_free(priv->used_rxkeys);
        kfree(priv->survey);
        priv->iq_autocal = NULL;
        priv->output_limit = NULL;