gbm: remove fprintf calls in gbm_dri_bo_create
authorSimon Ser <contact@emersion.fr>
Wed, 17 Mar 2021 08:09:48 +0000 (09:09 +0100)
committerMarge Bot <eric+marge@anholt.net>
Wed, 17 Mar 2021 20:47:52 +0000 (20:47 +0000)
These errors can be handled by the caller. The caller can't guess
whether the GBM implementation supports modifiers, for instance.

Signed-off-by: Simon Ser <contact@emersion.fr>
References: https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7601#note_778845
Reviewed-by: Daniel Stone <daniel@fooishbar.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8715>

src/gbm/backends/dri/gbm_dri.c

index f381754..856e691 100644 (file)
@@ -1152,7 +1152,6 @@ gbm_dri_bo_create(struct gbm_device *gbm,
    if (modifiers) {
       if (!dri->image || dri->image->base.version < 14 ||
           !dri->image->createImageWithModifiers) {
-         fprintf(stderr, "Modifiers specified, but DRI is too old\n");
          errno = ENOSYS;
          goto failed;
       }
@@ -1171,7 +1170,6 @@ gbm_dri_bo_create(struct gbm_device *gbm,
          }
       }
       if (!has_valid_modifier) {
-         fprintf(stderr, "Only invalid modifier specified\n");
          errno = EINVAL;
          goto failed;
       }