media: dw100: Convert to platform remove callback returning void

The .remove() callback for a platform driver returns an int which makes
many driver authors wrongly assume it's possible to do error handling by
returning an error code. However the value returned is (mostly) ignored
and this typically results in resource leaks. To improve here there is a
quest to make the remove callback return void. In the first step of this
quest all drivers are converted to .remove_new() which already returns
void.

Trivially convert this driver from always returning zero in the remove
callback to the void returning variant.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Reviewed-by: Xavier Roumegue <xavier.roumegue@oss.nxp.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

diff --git a/drivers/media/platform/nxp/dw100/dw100.c b/drivers/media/platform/nxp/dw100/dw100.c
index 0771a88..0024d61 100644 (file)
--- a/drivers/media/platform/nxp/dw100/dw100.c
+++ b/drivers/media/platform/nxp/dw100/dw100.c
@@ -1631,7 +1631,7 @@ err_pm:
        return ret;
 }
 
-static int dw100_remove(struct platform_device *pdev)
+static void dw100_remove(struct platform_device *pdev)
 {
        struct dw100_device *dw_dev = platform_get_drvdata(pdev);
 
@@ -1647,8 +1647,6 @@ static int dw100_remove(struct platform_device *pdev)
        mutex_destroy(dw_dev->vfd.lock);
        v4l2_m2m_release(dw_dev->m2m_dev);
        v4l2_device_unregister(&dw_dev->v4l2_dev);
-
-       return 0;
 }
 
 static int __maybe_unused dw100_runtime_suspend(struct device *dev)
@@ -1690,7 +1688,7 @@ MODULE_DEVICE_TABLE(of, dw100_dt_ids);
 
 static struct platform_driver dw100_driver = {
        .probe          = dw100_probe,
-       .remove         = dw100_remove,
+       .remove_new     = dw100_remove,
        .driver         = {
                .name   = DRV_NAME,
                .pm = &dw100_pm,