usb: Remove CONFIG_USBD_HS
authorTom Rini <trini@konsulko.com>
Fri, 2 Dec 2022 21:42:49 +0000 (16:42 -0500)
committerTom Rini <trini@konsulko.com>
Thu, 22 Dec 2022 15:31:49 +0000 (10:31 -0500)
This define is not enabled by the only platform which currently enables
the legacy option of CONFIG_USB_DEVICE. We can drop this code.

Signed-off-by: Tom Rini <trini@konsulko.com>
22 files changed:
README
drivers/serial/usbtty.c
drivers/serial/usbtty.h
drivers/usb/gadget/ep0.c
include/configs/apalis_imx6.h
include/configs/colibri-imx6ull.h
include/configs/colibri_imx6.h
include/configs/colibri_imx7.h
include/configs/ge_b1x5v2.h
include/configs/gw_ventana.h
include/configs/imx7-cm.h
include/configs/librem5.h
include/configs/mx6sabre_common.h
include/configs/mx7dsabresd.h
include/configs/nitrogen6x.h
include/configs/novena.h
include/configs/pico-imx6ul.h
include/configs/siemens-am33x-common.h
include/configs/tbs2910.h
include/configs/warp7.h
include/usbdescriptors.h
include/usbdevice.h

diff --git a/README b/README
index c8f6b21..2944646 100644 (file)
--- a/README
+++ b/README
@@ -618,14 +618,6 @@ The following options need to be configured:
                variable usbtty to be cdc_acm should suffice. The following
                might be defined in YourBoardName.h
 
-                       CONFIG_USBD_HS
-                       Define this to enable the high speed support for usb
-                       device and usbtty. If this feature is enabled, a routine
-                       int is_usbd_high_speed(void)
-                       also needs to be defined by the driver to dynamically poll
-                       whether the enumeration has succeded at high speed or full
-                       speed.
-
                If you have a USB-IF assigned VendorID then you may wish to
                define your own vendor specific values either in BoardName.h
                or directly in usbd_vendor_info.h. If you don't define
index 4f4eb02..07a59ec 100644 (file)
@@ -120,20 +120,6 @@ static struct usb_device_descriptor device_descriptor = {
        .bNumConfigurations =   NUM_CONFIGS
 };
 
-
-#if defined(CONFIG_USBD_HS)
-static struct usb_qualifier_descriptor qualifier_descriptor = {
-       .bLength = sizeof(struct usb_qualifier_descriptor),
-       .bDescriptorType =      USB_DT_QUAL,
-       .bcdUSB =               cpu_to_le16(USB_BCD_VERSION),
-       .bDeviceClass =         COMMUNICATIONS_DEVICE_CLASS,
-       .bDeviceSubClass =      0x00,
-       .bDeviceProtocol =      0x00,
-       .bMaxPacketSize0 =      EP0_MAX_PACKET_SIZE,
-       .bNumConfigurations =   NUM_CONFIGS
-};
-#endif
-
 /*
  * Static CDC ACM specific descriptors
  */
@@ -639,9 +625,6 @@ static void usbtty_init_instances (void)
        memset (device_instance, 0, sizeof (struct usb_device_instance));
        device_instance->device_state = STATE_INIT;
        device_instance->device_descriptor = &device_descriptor;
-#if defined(CONFIG_USBD_HS)
-       device_instance->qualifier_descriptor = &qualifier_descriptor;
-#endif
        device_instance->event = usbtty_event_handler;
        device_instance->cdc_recv_setup = usbtty_cdc_setup;
        device_instance->bus = bus_instance;
@@ -755,10 +738,6 @@ static void usbtty_init_terminal_type(short type)
                        device_descriptor.idProduct =
                                cpu_to_le16(CONFIG_USBD_PRODUCTID_CDCACM);
 
-#if defined(CONFIG_USBD_HS)
-                       qualifier_descriptor.bDeviceClass =
-                               COMMUNICATIONS_DEVICE_CLASS;
-#endif
                        /* Assign endpoint indices */
                        tx_endpoint = ACM_TX_ENDPOINT;
                        rx_endpoint = ACM_RX_ENDPOINT;
@@ -787,9 +766,6 @@ static void usbtty_init_terminal_type(short type)
                        device_descriptor.bDeviceClass = 0xFF;
                        device_descriptor.idProduct =
                                cpu_to_le16(CONFIG_USBD_PRODUCTID_GSERIAL);
-#if defined(CONFIG_USBD_HS)
-                       qualifier_descriptor.bDeviceClass = 0xFF;
-#endif
                        /* Assign endpoint indices */
                        tx_endpoint = GSERIAL_TX_ENDPOINT;
                        rx_endpoint = GSERIAL_RX_ENDPOINT;
@@ -937,9 +913,6 @@ static int usbtty_configured (void)
 static void usbtty_event_handler (struct usb_device_instance *device,
                                  usb_device_event_t event, int data)
 {
-#if defined(CONFIG_USBD_HS)
-       int i;
-#endif
        switch (event) {
        case DEVICE_RESET:
        case DEVICE_BUS_INACTIVE:
@@ -950,29 +923,6 @@ static void usbtty_event_handler (struct usb_device_instance *device,
                break;
 
        case DEVICE_ADDRESS_ASSIGNED:
-#if defined(CONFIG_USBD_HS)
-               /*
-                * is_usbd_high_speed routine needs to be defined by
-                * specific gadget driver
-                * It returns true if device enumerates at High speed
-                * Retuns false otherwise
-                */
-               for (i = 0; i < NUM_ENDPOINTS; i++) {
-                       if (((ep_descriptor_ptrs[i]->bmAttributes &
-                             USB_ENDPOINT_XFERTYPE_MASK) ==
-                             USB_ENDPOINT_XFER_BULK)
-                           && is_usbd_high_speed()) {
-
-                               ep_descriptor_ptrs[i]->wMaxPacketSize =
-                                       CONFIG_USBD_SERIAL_BULK_HS_PKTSIZE;
-                       }
-
-                       endpoint_instance[i + 1].tx_packetSize =
-                               ep_descriptor_ptrs[i]->wMaxPacketSize;
-                       endpoint_instance[i + 1].rcv_packetSize =
-                               ep_descriptor_ptrs[i]->wMaxPacketSize;
-               }
-#endif
                usbtty_init_endpoints ();
 
        default:
index e27aa36..ac4d220 100644 (file)
 #define CONFIG_USBD_SERIAL_INT_PKTSIZE UDC_INT_PACKET_SIZE
 #define CONFIG_USBD_SERIAL_BULK_PKTSIZE        UDC_BULK_PACKET_SIZE
 
-#if defined(CONFIG_USBD_HS)
-#define CONFIG_USBD_SERIAL_BULK_HS_PKTSIZE     UDC_BULK_HS_PACKET_SIZE
-#endif
-
 #define USBTTY_DEVICE_CLASS    COMMUNICATIONS_DEVICE_CLASS
 
 #define USBTTY_BCD_DEVICE      0x00
index 6624f61..c256cc3 100644 (file)
@@ -371,26 +371,7 @@ static int ep0_get_descriptor (struct usb_device_instance *device,
                }
                break;
        case USB_DESCRIPTOR_TYPE_DEVICE_QUALIFIER:
-#if defined(CONFIG_USBD_HS)
-               {
-                       struct usb_qualifier_descriptor *qualifier_descriptor =
-                               device->qualifier_descriptor;
-
-                       if (!qualifier_descriptor)
-                               return -1;
-
-                       /* copy descriptor for this device */
-                       copy_config(urb, qualifier_descriptor,
-                                       sizeof(struct usb_qualifier_descriptor),
-                                       max);
-
-               }
-               dbg_ep0(3, "copied qualifier descriptor, actual_length: 0x%x",
-                               urb->actual_length);
-#else
                return -1;
-#endif
-               break;
 
        default:
                return -1;
index 25a8445..07587c7 100644 (file)
@@ -28,8 +28,6 @@
 /* Host */
 #define CONFIG_MXC_USB_PORTSC          (PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CONFIG_MXC_USB_FLAGS           0
-/* Client */
-#define CONFIG_USBD_HS
 
 /* Framebuffer and LCD */
 
index 2f09a26..6f3524d 100644 (file)
 #define CONFIG_MXC_USB_PORTSC          (PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CONFIG_MXC_USB_FLAGS           0
 
-#define CONFIG_USBD_HS
-
 /* USB Device Firmware Update support */
 #define DFU_DEFAULT_POLL_TIMEOUT       300
 
index 19daad2..4e51df1 100644 (file)
@@ -25,8 +25,6 @@
 /* Host */
 #define CONFIG_MXC_USB_PORTSC          (PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CONFIG_MXC_USB_FLAGS           0
-/* Client */
-#define CONFIG_USBD_HS
 
 /* Command definition */
 
index 48c3f01..89546b8 100644 (file)
 #define CONFIG_MXC_USB_PORTSC          (PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CONFIG_MXC_USB_FLAGS           0
 
-#define CONFIG_USBD_HS
-
 #endif
index 1458b18..1aaa3e6 100644 (file)
@@ -26,7 +26,6 @@
 /* USB */
 #define CONFIG_MXC_USB_PORTSC          (PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CONFIG_MXC_USB_FLAGS           0
-#define CONFIG_USBD_HS
 
 /* Memory */
 #define PHYS_SDRAM                    MMDC0_ARB_BASE_ADDR
index 298a8f5..5a78c68 100644 (file)
@@ -38,7 +38,6 @@
 /* USB Configs */
 #define CONFIG_MXC_USB_PORTSC     (PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CONFIG_MXC_USB_FLAGS      0
-#define CONFIG_USBD_HS
 
 /* Miscellaneous configurable options */
 
index 76771fd..8e9dbef 100644 (file)
@@ -81,6 +81,4 @@
 /* USB Configs */
 #define CONFIG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 
-#define CONFIG_USBD_HS
-
 #endif /* __CONFIG_H */
index 11b3fa6..377e3e7 100644 (file)
@@ -27,8 +27,6 @@
 
 #define CFG_SYS_FSL_USDHC_NUM  2
 
-#define CONFIG_USBD_HS
-
 #define CONSOLE_ON_UART1
 
 #ifdef CONSOLE_ON_UART1
index 6294fd1..96a48a9 100644 (file)
 
 /* Environment organization */
 
-#define CONFIG_USBD_HS
-
 #endif                         /* __MX6QSABRE_COMMON_CONFIG_H */
index 6c16552..bd70b62 100644 (file)
 /* USB Configs */
 #define CONFIG_MXC_USB_PORTSC  (PORT_PTS_UTMI | PORT_PTS_PTW)
 
-#define CONFIG_USBD_HS
-
 #endif /* __CONFIG_H */
index 5020b3b..1d10197 100644 (file)
@@ -11,8 +11,6 @@
 
 #include "mx6_common.h"
 
-#define CONFIG_USBD_HS
-
 #define CONFIG_MXC_UART_BASE          UART2_BASE
 
 /* MMC Configs */
index 79e49c7..b0d473e 100644 (file)
@@ -55,8 +55,6 @@
 #ifdef CONFIG_CMD_USB
 #define CONFIG_MXC_USB_PORTSC          (PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CONFIG_MXC_USB_FLAGS           0
-/* Gadget part */
-#define CONFIG_USBD_HS
 #endif
 
 /* Extra U-Boot environment. */
index 8af8883..faf11d5 100644 (file)
@@ -26,8 +26,6 @@
 #define CONFIG_MXC_USB_PORTSC          (PORT_PTS_UTMI | PORT_PTS_PTW)
 #define CONFIG_MXC_USB_FLAGS           0
 
-#define CONFIG_USBD_HS
-
 #define DFU_DEFAULT_POLL_TIMEOUT 300
 
 #define CONFIG_DFU_ENV_SETTINGS \
index 1b1787a..406a179 100644 (file)
@@ -70,9 +70,6 @@
  * we don't need to do it twice.
  */
 
-/* USB DRACO ID as default */
-#define CONFIG_USBD_HS
-
 /* USB Device Firmware Update support */
 #define DFU_MANIFEST_POLL_TIMEOUT      25000
 
index fcc9674..689914c 100644 (file)
@@ -28,9 +28,6 @@
 /* USB */
 #ifdef CONFIG_CMD_USB
 #define CONFIG_MXC_USB_PORTSC          (PORT_PTS_UTMI | PORT_PTS_PTW)
-#ifdef CONFIG_CMD_USB_MASS_STORAGE
-#define CONFIG_USBD_HS
-#endif /* CONFIG_CMD_USB_MASS_STORAGE */
 #endif /* CONFIG_CMD_USB      */
 
 #define CONFIG_EXTRA_ENV_SETTINGS \
index 56c90aa..a985c6f 100644 (file)
@@ -95,8 +95,6 @@
 
 #define CONFIG_MXC_USB_PORTSC          (PORT_PTS_UTMI | PORT_PTS_PTW)
 
-#define CONFIG_USBD_HS
-
 /* USB Device Firmware Update support */
 #define DFU_DEFAULT_POLL_TIMEOUT       300
 
index 9a50387..641b4a3 100644 (file)
@@ -227,21 +227,6 @@ struct usb_device_descriptor {
        u8 bNumConfigurations;
 } __attribute__ ((packed));
 
-#if defined(CONFIG_USBD_HS)
-struct usb_qualifier_descriptor {
-       u8 bLength;
-       u8 bDescriptorType;
-
-       u16 bcdUSB;
-       u8 bDeviceClass;
-       u8 bDeviceSubClass;
-       u8 bDeviceProtocol;
-       u8 bMaxPacketSize0;
-       u8 bNumConfigurations;
-       u8 breserved;
-} __attribute__ ((packed));
-#endif
-
 struct usb_string_descriptor {
        u8 bLength;
        u8 bDescriptorType;     /* 0x03 */
index 611cd6e..80c5af0 100644 (file)
@@ -196,10 +196,6 @@ struct usb_bus_instance;
 #define USB_DT_INTERFACE               0x04
 #define USB_DT_ENDPOINT                        0x05
 
-#if defined(CONFIG_USBD_HS)
-#define USB_DT_QUAL                    0x06
-#endif
-
 #define USB_DT_HID                     (USB_TYPE_CLASS | 0x01)
 #define USB_DT_REPORT                  (USB_TYPE_CLASS | 0x02)
 #define USB_DT_PHYSICAL                        (USB_TYPE_CLASS | 0x03)
@@ -279,11 +275,7 @@ struct usb_bus_instance;
  * USB Spec Release number
  */
 
-#if defined(CONFIG_USBD_HS)
-#define USB_BCD_VERSION                        0x0200
-#else
 #define USB_BCD_VERSION                        0x0110
-#endif
 
 
 /*
@@ -552,9 +544,6 @@ struct usb_device_instance {
        /* generic */
        char *name;
        struct usb_device_descriptor *device_descriptor;        /* per device descriptor */
-#if defined(CONFIG_USBD_HS)
-       struct usb_qualifier_descriptor *qualifier_descriptor;
-#endif
 
        void (*event) (struct usb_device_instance *device, usb_device_event_t event, int data);
 
@@ -644,14 +633,6 @@ struct usb_string_descriptor *usbd_get_string (u8);
 struct usb_device_descriptor *usbd_device_device_descriptor(struct
                usb_device_instance *, int);
 
-#if defined(CONFIG_USBD_HS)
-/*
- * is_usbd_high_speed routine needs to be defined by specific gadget driver
- * It returns true if device enumerates at High speed
- * Retuns false otherwise
- */
-int is_usbd_high_speed(void);
-#endif
 int usbd_endpoint_halted (struct usb_device_instance *device, int endpoint);
 void usbd_rcv_complete(struct usb_endpoint_instance *endpoint, int len, int urb_bad);
 void usbd_tx_complete (struct usb_endpoint_instance *endpoint);