Fix ASAN issue : heap-use-after-free

[Version] 1.1.3
[Issue Type] ASAN

Change-Id: I54ed52ae0b94c3fdd595266ceda5185bb5656958
Signed-off-by: Jeongmo Yang <jm80.yang@samsung.com>

diff --git a/packaging/capi-media-codec.spec b/packaging/capi-media-codec.spec
index e13c349a7268080c14912ec3324da6b6748b1293..db1a2540b3180b77a0b4bbf31f0237b70733db97 100644 (file)
--- a/packaging/capi-media-codec.spec
+++ b/packaging/capi-media-codec.spec
@@ -4,7 +4,7 @@
 
 Name:       capi-media-codec
 Summary:    A Media Codec library in Tizen Native API
-Version:    1.1.2
+Version:    1.1.3
 Release:    0
 Group:      Multimedia/API
 License:    Apache-2.0

diff --git a/src/media_codec.c b/src/media_codec.c
index 732a76d9ed4e02a558efa17f2d590872a00578ce..599cc49aee69f81d95a208a1c2e4914f73a07bb1 100644 (file)
--- a/src/media_codec.c
+++ b/src/media_codec.c
@@ -146,10 +146,6 @@ int mediacodec_create(mediacodec_h *mediacodec)
                handle = NULL;
                return MEDIACODEC_ERROR_INVALID_OPERATION;
 //LCOV_EXCL_STOP
-       } else {
-               *mediacodec = (mediacodec_h)handle;
-               handle->state = MEDIACODEC_STATE_IDLE;
-               LOGD("new handle : %p", *mediacodec);
        }
 
        /* set callback */
@@ -174,6 +170,11 @@ int mediacodec_create(mediacodec_h *mediacodec)
        }
 #endif
 
+       handle->state = MEDIACODEC_STATE_IDLE;
+       *mediacodec = (mediacodec_h)handle;
+
+       LOGD("new handle : %p", *mediacodec);
+
        return MEDIACODEC_ERROR_NONE;
 
 }