Staging: comedi: fix multiple line dereference coding style issue in cb_pcidas64.c
authorJian Zhang <kernel@ubicomp.com.au>
Fri, 23 Mar 2018 10:49:09 +0000 (18:49 +0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Fri, 23 Mar 2018 14:55:21 +0000 (15:55 +0100)
This is a patch to the cb_pcidas64.c file that fixes up a multiple line
dereference warning found by the checkpatch.pl tool.

Signed-off-by: Jian Zhang <kernel@ubicomp.com.au>
Reviewed-by: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/comedi/drivers/cb_pcidas64.c

index 942ba5c..fdd81c3 100644 (file)
@@ -2462,20 +2462,21 @@ static int setup_channel_queue(struct comedi_device *dev,
                        writew(0, devpriv->main_iobase + ADC_QUEUE_CLEAR_REG);
                        /* load external queue */
                        for (i = 0; i < cmd->chanlist_len; i++) {
+                               unsigned int chanspec = cmd->chanlist[i];
+                               int use_differential;
+
                                bits = 0;
                                /* set channel */
-                               bits |= adc_chan_bits(CR_CHAN(cmd->
-                                                             chanlist[i]));
+                               bits |= adc_chan_bits(CR_CHAN(chanspec));
                                /* set gain */
                                bits |= ai_range_bits_6xxx(dev,
-                                                          CR_RANGE(cmd->
-                                                                   chanlist
-                                                                   [i]));
+                                                          CR_RANGE(chanspec));
                                /* set single-ended / differential */
-                               bits |= se_diff_bit_6xxx(dev,
-                                                        CR_AREF(cmd->
-                                                                chanlist[i]) ==
-                                                        AREF_DIFF);
+                               use_differential = 0;
+                               if (CR_AREF(chanspec) == AREF_DIFF)
+                                       use_differential = 1;
+                               bits |= se_diff_bit_6xxx(dev, use_differential);
+
                                if (CR_AREF(cmd->chanlist[i]) == AREF_COMMON)
                                        bits |= ADC_COMMON_BIT;
                                /* mark end of queue */